Date:   Wed, 24 Nov 2021 09:21:03 +0800
From:   Aili Yao <yaoaili126@gmail.com>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        bsegall@google.com, mgorman@suse.de, linux-kernel@vger.kernel.org,
        yaoaili@kingsoft.com
Subject: Re: [PATCH] sched/isolation: delete redundant
 housekeeping_overridden check
Message-ID: <20211124092103.64e93376@gmail.com>
In-Reply-To: <20211123123852.11a84a9e@gandalf.local.home>
References: <20211123154535.48be4399@gmail.com>
        <20211123123852.11a84a9e@gandalf.local.home>
Organization: ksyun
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 23 Nov 2021 12:38:52 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 23 Nov 2021 15:45:35 +0800
> Aili Yao <yaoaili126@gmail.com> wrote:
> 
> > From: Aili Yao <yaoaili@kingsoft.com>
> > 
> > housekeeping_test_cpu is only called by housekeeping_cpu(),
> > and in housekeeping_cpu(), there is already one same check;
> > 
> > So delete the redundant check.
> > 
> > Signed-off-by: Aili Yao <yaoaili@kingsoft.com>
> > ---
> >  kernel/sched/isolation.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/kernel/sched/isolation.c b/kernel/sched/isolation.c
> > index 7f06eaf..5c4d533 100644
> > --- a/kernel/sched/isolation.c
> > +++ b/kernel/sched/isolation.c
> > @@ -56,9 +56,8 @@ void housekeeping_affine(struct task_struct *t, enum
> > hk_flags flags) 
> >  bool housekeeping_test_cpu(int cpu, enum hk_flags flags)
> >  {
> > -	if (static_branch_unlikely(&housekeeping_overridden))
> > -		if (housekeeping_flags & flags)
> > -			return cpumask_test_cpu(cpu,
> > housekeeping_mask);  
> 
> Not only is your email client broken, you don't seem to understand what
> static_branch_unlikely() is.

Yes, My mail client is not properly configured, sorry for that, I will make it work.

And Yes again, I have limited knowledge about static key, But still don't understand why we
need two same check(jump or nop instruction?) here, could you be kindly to explain this?

A lot Thanks!
Aili Yao