Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FF4DC4332F for ; Wed, 24 Nov 2021 01:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234096AbhKXBk3 (ORCPT ); Tue, 23 Nov 2021 20:40:29 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:56724 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229729AbhKXBk2 (ORCPT ); Tue, 23 Nov 2021 20:40:28 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 73551FFED5; Tue, 23 Nov 2021 20:37:18 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=gPS7B65AmWqs FpzTYgE45rgBpx9lbpMrdgQ/IUoEl44=; b=MNemlHC5ze2N/bzWtqgskb/Oc0Zk 4QFtZZ7qZSuiwyij32muHjcopJ2OtVSDxvqI9iH7fN9cPJzZzNeQfaLXGXGEVKjX YIs9bB5VzqJ/95YV36zcjnq92NZ1FlzXDOOb2Hj5TQcDLFBJl5yDABe6fVLteBkW dVw3UzrUgK5cCVE= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 6AE3FFFED4; Tue, 23 Nov 2021 20:37:18 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id AF733FFED3; Tue, 23 Nov 2021 20:37:17 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Eric Wong Cc: Thorsten Leemhuis , workflows@vger.kernel.org, linux-kernel@vger.kernel.org, Konstantin Ryabitsev , Jonathan Corbet , git@vger.kernel.org Subject: Re: [RFC PATCH v1 1/1] docs: add the new commit-msg tags 'Reported:' and 'Reviewed:' References: <6b760115ecdd3687d4b82680b284f55a04f3ad90.1637566224.git.linux@leemhuis.info> <20211123185237.M476855@dcvr> Date: Tue, 23 Nov 2021 17:37:16 -0800 In-Reply-To: <20211123185237.M476855@dcvr> (Eric Wong's message of "Tue, 23 Nov 2021 18:52:37 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 0F1D462C-4CC7-11EC-B0BF-62A2C8D8090B-77302942!pb-smtp1.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Wong writes: > git send-email's capitalization does annoy me and I've looked > into changing it; but there's a bunch of tests and probably > dependent code that also need to be updated... It does annoy me, too, and I do not mind if it gets "fixed", but I do not know if the cost for vetting a bulk update like that is worth it. There is another one outside send-email in log-tree.c that is responsible for output from format-patch. Here is the extent of damage in my trial change that seems to pass the tests locally. Documentation/MyFirstContribution.txt | 14 ++++----- Documentation/git-format-patch.txt | 4 +-- Documentation/git-send-email.txt | 2 +- git-send-email.perl | 4 +-- log-tree.c | 2 +- mailinfo.c | 4 +-- t/t4014-format-patch.sh | 56 +++++++++++++++++------------= ------ t/t4150-am.sh | 8 ++--- t/t4258/mbox | 2 +- t/t5100/msg0002 | 2 +- t/t5100/msg0003 | 2 +- t/t5100/msg0012--message-id | 2 +- t/t5100/quoted-cr.mbox | 4 +-- t/t5100/sample.mbox | 6 ++-- t/t9001-send-email.sh | 38 ++++++++++++------------ 15 files changed, 75 insertions(+), 75 deletions(-) diff --git i/Documentation/MyFirstContribution.txt w/Documentation/MyFirs= tContribution.txt index b20bc8e914..91cb204d52 100644 --- i/Documentation/MyFirstContribution.txt +++ w/Documentation/MyFirstContribution.txt @@ -1071,21 +1071,21 @@ between your last version and now, if it's someth= ing significant. You do not need the exact same body in your second cover letter; focus on explainin= g to reviewers the changes you've made that may not be as visible. =20 -You will also need to go and find the Message-Id of your previous cover = letter. +You will also need to go and find the Message-ID of your previous cover = letter. You can either note it when you send the first series, from the output o= f `git send-email`, or you can look it up on the https://lore.kernel.org/git[mailing list]. Find your cover letter in the -archives, click on it, then click "permalink" or "raw" to reveal the Mes= sage-Id +archives, click on it, then click "permalink" or "raw" to reveal the Mes= sage-ID header. It should match: =20 ---- -Message-Id: +Message-ID: ---- =20 -Your Message-Id is ``. This example will b= e used -below as well; make sure to replace it with the correct Message-Id for y= our -**previous cover letter** - that is, if you're sending v2, use the Messa= ge-Id -from v1; if you're sending v3, use the Message-Id from v2. +Your Message-ID is ``. This example will b= e used +below as well; make sure to replace it with the correct Message-ID for y= our +**previous cover letter** - that is, if you're sending v2, use the Messa= ge-ID +from v1; if you're sending v3, use the Message-ID from v2. =20 While you're looking at the email, you should also note who is CC'd, as = it's common practice in the mailing list to keep all CCs on a thread. You can= add diff --git i/Documentation/git-format-patch.txt w/Documentation/git-forma= t-patch.txt index 113eabc107..daf911f249 100644 --- i/Documentation/git-format-patch.txt +++ w/Documentation/git-format-patch.txt @@ -99,7 +99,7 @@ To omit patch numbers from the subject, use `-N`. =20 If given `--thread`, `git-format-patch` will generate `In-Reply-To` and `References` headers to make the second and subsequent patch mails appea= r -as replies to the first mail; this also generates a `Message-Id` header = to +as replies to the first mail; this also generates a `Message-ID` header = to reference. =20 OPTIONS @@ -163,7 +163,7 @@ include::diff-options.txt[] --no-thread:: Controls addition of `In-Reply-To` and `References` headers to make the second and subsequent mails appear as replies to the - first. Also controls generation of the `Message-Id` header to + first. Also controls generation of the `Message-ID` header to reference. + The optional