To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Janne Grunau <j@jannau.net>, Sven Peter <sven@svenpeter.dev>,
        Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211122225807.8105-1-j@jannau.net>
 <20211122225807.8105-4-j@jannau.net>
 <5f16c962-72a1-21ec-9651-744053f74365@marcan.st>
 <d48d2e85-42f1-570a-bd8f-e3834147c8b8@marcan.st>
 <CACRpkdZghfRvox4aY4ROXYwFqiV6mnXZgw+42ZWYisXXgQ5+jQ@mail.gmail.com>
From:   Hector Martin <marcan@marcan.st>
Subject: Re: [PATCH v3 3/4] arm64: dts: apple: t8103: Add i2c nodes
Message-ID: <f13b54bd-d776-0d06-113a-5ca2bcbccfcd@marcan.st>
Date:   Wed, 24 Nov 2021 14:42:12 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <CACRpkdZghfRvox4aY4ROXYwFqiV6mnXZgw+42ZWYisXXgQ5+jQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: es-ES
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 24/11/2021 08.26, Linus Walleij wrote:
> On Tue, Nov 23, 2021 at 3:43 PM Hector Martin <marcan@marcan.st> wrote:
> 
>> For those following along in the list: the reason why i2c3 was getting
>> stuck is because it seems the unused bus is weakly pulled low on these
>> machines, which jams it.
> 
> That looks like some power saving attempt.
> 
> I suppose that means that even i2c buses that are in use
> could be weakly pulled low when suspending the system
> and maybe even inbetween transactions to save some
> leak current.

Pulled up vs. down dosn't really result in better power savings; neither 
state will necessarily have more leakage. I think it's just that the 
pins are completely disconnected, and there's some very minor leakage to 
ground (megaohms will do) that ends up pulling them down.

Pulling down an I2C bus between transactions is not legal; the idle 
state has to be high.

Apple are actually not very good at configuring GPIOs for power saving; 
e.g. the I/Os for that unused i2c bus still have their input buffers 
turned on, which is a waste of power. If they wanted to save the 
smallest drop of power they'd turn that off. But the effect of this is 
so trivial it probably makes no difference in the context of a laptop, 
nevermind a desktop like the Mac Mini.

-- 
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub