IronPort-SDR: /HMDUhn/N4fQQvzwOzOG8BE+T3sOSOE48H6iiNTkIMM5mnnYdXOX+uzLXIpkJIblJVwi72Mxy3
 VJSLUsrwGmY5Ra5Pe67+Qwg7JL3hcYucskXANwrHklJFlvUPINzsERhWW4mkMuNSoy998rjNQK
 mKvhz9hItb8mvsL/z6eixzl4A+HU7W8rC8MR2dqWeAy5Qigfm3CoiGVaJPGOowlUVggAMmP8rD
 GxsDGODJZ93tfGn5lEzuypQnwJJSJ7BB2FuVVrOMp890dIUebhJbdifMrugRpsXhADvo7lr4xG
 xHQP8VB0If4xzckW4qU1bHIE
Date:   Wed, 24 Nov 2021 09:13:21 +0100
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Denis Kirjanov <dkirjanov@suse.de>
CC:     <davem@davemloft.net>, <kuba@kernel.org>, <robh+dt@kernel.org>,
        <UNGLinuxDriver@microchip.com>, <p.zabel@pengutronix.de>,
        <linux@armlinux.org.uk>, <netdev@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 2/6] net: lan966x: add the basic lan966x
 driver
Message-ID: <20211124081321.qbxhbbathz7nduuu@soft-dev3-1.localhost>
References: <20211123135517.4037557-1-horatiu.vultur@microchip.com>
 <20211123135517.4037557-3-horatiu.vultur@microchip.com>
 <16727fc4-4cc7-41de-910d-80b3bca70ef1@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <16727fc4-4cc7-41de-910d-80b3bca70ef1@suse.de>
Precedence: bulk

The 11/23/2021 18:31, Denis Kirjanov wrote:
> 
Hi Denis,

> > +static int lan966x_probe_port(struct lan966x *lan966x, u32 p,
> > +                           phy_interface_t phy_mode)
> > +{
> > +     struct lan966x_port *port;
> > +
> > +     if (p >= lan966x->num_phys_ports)
> > +             return -EINVAL;
> > +
> > +     port = devm_kzalloc(lan966x->dev, sizeof(*port), GFP_KERNEL);
> ENOMEM?

I will add this, even though the next patch in the series will change this.

> > +
> > +     port->lan966x = lan966x;
> > +     port->chip_port = p;
> > +     port->pvid = PORT_PVID;
> > +     lan966x->ports[p] = port;
> > +
> > +     return 0;
> > +}
> > +

...

> > +
> > +     /* go over the child nodes */
> > +     fwnode_for_each_available_child_node(ports, portnp) {
> > +             phy_interface_t phy_mode;
> > +             u32 p;
> > +
> > +             if (fwnode_property_read_u32(portnp, "reg", &p))
> > +                     continue;
> > +
> > +             phy_mode = fwnode_get_phy_mode(portnp);
> > +             err = lan966x_probe_port(lan966x, p, phy_mode);
> > +             if (err)
> > +                     return err;
> > +     }
> > +
> > +     return 0;
> You have to properly free allocated resource in the error case

Yes, I will need to call, fwnode_handle_put(portnp), like it is done in
the next patch.

> > +}
> > +
> > +static int lan966x_remove(struct platform_device *pdev)
> > +{
> > +     return 0;
> > +}
> > +
> > 

-- 
/Horatiu