Date:   Wed, 24 Nov 2021 09:52:50 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Cai Huoqing <caihuoqing@baidu.com>
Cc:     Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/3] staging: zynpu: Add driver support for ARM(China)
 ZHOUYI AI accelerator
Message-ID: <YZ39YqsNTSolEJZ2@kroah.com>
References: <20211124084620.628-1-caihuoqing@baidu.com>
 <20211124084620.628-2-caihuoqing@baidu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211124084620.628-2-caihuoqing@baidu.com>
Precedence: bulk

On Wed, Nov 24, 2021 at 04:46:15PM +0800, Cai Huoqing wrote:
> ZHOUYI NPU is an AI accelerator chip which is integrated into ARM SOC,
> such as Allwinner R329 SOC.
> Add driver support for this AI accelerator here.
> 
> This driver is not tandard linux style, there are some clean up works,

"standard"?

> fixing code style, refactorring.
> And it only works with a closed source usermode driver, so need to
> reverse the libraries, and impelement it, then open source
> the usermode driver.

Who will be doing the "reversing" of the usermode driver?

We can't take this now if there's no actual users of this code that
anyone can test.  Why not just change the license of the usermode code
now to make this simpler?

thanks,

greg k-h