Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD616C433FE for ; Wed, 24 Nov 2021 09:15:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241004AbhKXJSR (ORCPT ); Wed, 24 Nov 2021 04:18:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:46128 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235484AbhKXJSQ (ORCPT ); Wed, 24 Nov 2021 04:18:16 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id B46FA60462; Wed, 24 Nov 2021 09:15:03 +0000 (UTC) Date: Wed, 24 Nov 2021 10:15:00 +0100 From: Christian Brauner To: Arnd Bergmann Cc: Alexander Viro , "Russell King (Oracle)" , Arnd Bergmann , Jeff Layton , kernel test robot , Christoph Hellwig , Jan Kara , Jens Axboe , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/locks: fix fcntl_getlk64/fcntl_setlk64 stub prototypes Message-ID: <20211124091500.yi4vfi2a5e7frbqx@wittgenstein> References: <20211123160531.93545-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211123160531.93545-1-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 23, 2021 at 05:05:07PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > My patch to rework oabi fcntl64() introduced a harmless > sparse warning when file locking is disabled: > > arch/arm/kernel/sys_oabi-compat.c:251:51: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected struct flock64 [noderef] __user *user @@ got struct flock64 * @@ > arch/arm/kernel/sys_oabi-compat.c:251:51: sparse: expected struct flock64 [noderef] __user *user > arch/arm/kernel/sys_oabi-compat.c:251:51: sparse: got struct flock64 * > arch/arm/kernel/sys_oabi-compat.c:265:55: sparse: sparse: incorrect type in argument 4 (different address spaces) @@ expected struct flock64 [noderef] __user *user @@ got struct flock64 * @@ > arch/arm/kernel/sys_oabi-compat.c:265:55: sparse: expected struct flock64 [noderef] __user *user > arch/arm/kernel/sys_oabi-compat.c:265:55: sparse: got struct flock64 * > > When file locking is enabled, everything works correctly and the > right data gets passed, but the stub declarations in linux/fs.h > did not get modified when the calling conventions changed in an > earlier patch. > > Reported-by: kernel test robot > Fixes: 7e2d8c29ecdd ("ARM: 9111/1: oabi-compat: rework fcntl64() emulation") > Fixes: a75d30c77207 ("fs/locks: pass kernel struct flock to fcntl_getlk/setlk") > Cc: Christoph Hellwig > Signed-off-by: Arnd Bergmann > --- Looks good. Thanks! Acked-by: Christian Brauner