Message-ID: <1db3aae2-2b68-a18e-2ea7-3b193612125f@nvidia.com>
Date:   Wed, 24 Nov 2021 12:18:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH] net/bridge: replace simple_strtoul to kstrtol
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Ido Schimmel <idosch@idosch.org>, Bernard Zhao <bernard@vivo.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>,
        bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211119020642.108397-1-bernard@vivo.com>
 <YZtrM3Ukz7rKfNLN@shredder> <f98615d9-a129-d0b0-e444-cb649c14d7ce@nvidia.com>
 <20211123201327.3689203b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From:   Nikolay Aleksandrov <nikolay@nvidia.com>
In-Reply-To: <20211123201327.3689203b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWpUTWRiUUI2N1JDbDlCMjIwbHdaUDIrK2hJNWJPWjlUODZBaXhuUXpwMGky?=
 =?utf-8?B?emhXVlF5Zzk0SUJ5RHNiWGlaU1Y1V1JKWGlrOFAxbG54c3N4T1VsTGJsVEwr?=
 =?utf-8?B?NmdqR05zdXVWblJTSmtWYm5yRDJuZ21KL3dxS2UvRVpxVTJnYld5TFJmcFZ4?=
 =?utf-8?B?Qm9EL2F3aEFUbWZwU3lpZUpSMGpmdy9Hd3ZuY2E5S1VMN0hUQ0hJZC9zK0tl?=
 =?utf-8?B?bzhKb1ZnREJNb3NTMW5LT1cyREgyQjhDR3VUZm5FY3JlMFdyRVFNeHJlbFlr?=
 =?utf-8?B?RHExY3VkaUdPVzUwU0s5NzBuMUtVWndMbTZZaFFSSzF5a09OblJud2tCTGRF?=
 =?utf-8?B?QXhFc1puRG9xQnlFZnJzdVRNQ25UVU1rMGtOWGR3SXc4WE5ZQVk4MjdBalRN?=
 =?utf-8?B?Z1UvdjRtUmN0WldBMFRvM1luMXR5WEVLQVNWblJYYzZDbDJEUi9zUjU4UnQ4?=
 =?utf-8?B?MjhkRU52M0Yxd1dCL1NwY2EzQmNsbUR1aWYvMEl1SWpGdlpCK2o2SFdiMlhM?=
 =?utf-8?B?dzlIdzRxRS9kS1JCK1NXSTJ6V2NGTVpXY3hJSUQxdnNrWW9vdmZvR2JLdSsx?=
 =?utf-8?B?VW1tVXR4RDhSMnhDcWExSURYbllzaFM1TTVyTWhBRTlZbUNLTy9iWWovSjBt?=
 =?utf-8?B?ZFNDK0pBeXU2MWpNUGF4QzltczlJaW5JU3Q5SW9pN2VyQ0FxeDgvc2RGM1Bw?=
 =?utf-8?B?Qm9QMlo2bEFjWGtyZ05kd242UmwrWTQrS0R5MmkwOTdqS3NNNG1tNG1zNlJk?=
 =?utf-8?B?TGpaT0xVK2ZCZDdMc05FR1VTdml0M3VMZGRYbTFaeFdtUVpDMHRQdmcwajRy?=
 =?utf-8?B?SzNpOFBuaU02d0Y4WGpFQUZXYTJ6OGw1QWdHb2I4UXJ2aXBveThlSmhyM1NQ?=
 =?utf-8?B?WENCZ3pwNU53Wm44aE5Iek1yZUFERFViVWl5YkZiVWRBTHZrL1RwVldmMXdl?=
 =?utf-8?B?a2N4Qk1SeVJ2aFdDbm92cTN0dGRqL1ozY3c5U1paQ1BjajFEb0xrWjlGdHF1?=
 =?utf-8?B?L2FFd05ydjRoVnFRUWFUTE1yNTU3Z2ZTdnVEYkZoazd5N0RTbEJHSjRZMTJK?=
 =?utf-8?B?eUsxRmozZWpwV0g2UW9lS1VXNkFtbjhUTXdlZStJM1p6UGJxU25Hb0VjQ1Z2?=
 =?utf-8?B?MXI5c1lwaGkvSGh3RVdSNFpoK3VtUXl3bVM3bG5KMmxPT0hlMmtkRUo0TTFR?=
 =?utf-8?B?VHRzK2VvQTMybXNyYkEwVFNvQzhSdHdWSi9GdFJabjVOdE5DcjB6bER2Nkhn?=
 =?utf-8?B?bTZuSkVLSEQrN25xY1FnUkF0bUhCbDRNMGZWS2VMd1VXK1hqQ0Z2NVVJdkFv?=
 =?utf-8?B?YXN4QllpKzRQMlNjeCt4NUdKWlhqMlQwbjNMQnFHczgraExzaTgvcW9HN29M?=
 =?utf-8?B?VzBQTExrYmRPZXpaVDYyRkhWLzg2L1hONDhpQnJjUm5mNm96SUlnbE1KRExq?=
 =?utf-8?B?ekdrNEtnWitLbnVHYTFldzU4RklLM0VpWnZ0WHdscmtYZy9KRTl6UUlpeVNi?=
 =?utf-8?B?dU53dGxvaC9COWh1MDhjVGloYkEvcVovc2VicnRXNFFxenVRMWJzSTFkbFI2?=
 =?utf-8?B?UjB4S3FtSlA3a1ZnNW9hRFhZQmt5Q2RQUEowVTNLQ2Fwc01JK2g2QU1hSGJk?=
 =?utf-8?B?K3NOMEZVUlFIemRwWlNJMzFkMmlaTmpYQXdsUFlWVDBLRFhhSkg4dThrS29j?=
 =?utf-8?B?Tm83OC9EMVlNeEllV01pRktIbVVMaVBGNVZmRzFBajRRSlduYmZ2UnRGSnZo?=
 =?utf-8?B?NzFYSGNRM3Zub3IvdERIVG10T2hmUmZPQkV5a1AxODN0NGJYSjFQK3hKNWtH?=
 =?utf-8?B?a2JXWFZXK3hFRDVtdE9jZ3ZZbEhIZU9ZRGRtS1ZPdTdWZFF0dmhyeUFzYmFY?=
 =?utf-8?B?SUkwNVNKSlJhZ0JhMWxzVUpZUVhaeWduWklkMWxqd3I4ZlMrdGY3WUNvcnlv?=
 =?utf-8?B?L1BxRzR5dlk0czJnMmRpaUVKWTUwcVAyL2FHWVBrd29kUFI1NHZ6Q0thdHpn?=
 =?utf-8?B?OTgyMkl2TGFRZk9ydTY4a0NzK0o3ODNkYXRhYlRIZis2OW5mWlREZi9MZG5F?=
 =?utf-8?B?eGs4YzdTbWtWTzl6L3ZSblFicFJKN3N2dG04WldyQ2hMaG9ndGdHcHVFdnl2?=
 =?utf-8?B?NjFHMXVDeGNZMk1Tb1VBR1BMQkNrZ0lMQndNcVVLaGVIbk1pLzNxSmZBb0xm?=
 =?utf-8?Q?KBQoRlnFa4b1keecKFQAlLw=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34b4eaef-2522-4b36-b131-08d9af33cc92
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5278.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2021 10:18:46.3976
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CHzAFpAqVzYnWgekpVmr4HVlyobdvgFN9ICry14QkthX1g7kEE3+VRaptTob4fvhim0itb8bWgkw87ZdhO0Wyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5311
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24/11/2021 06:13, Jakub Kicinski wrote:
> On Mon, 22 Nov 2021 12:17:39 +0200 Nikolay Aleksandrov wrote:
>>> # ip link add name br0 type bridge vlan_filtering 1
>>> # echo "0x88a8" > /sys/class/net/br0/bridge/vlan_protocol 
>>> bash: echo: write error: Invalid argument
>>
>> Good catch, Bernard please send a revert. Thanks.
> 
> Doesn't look like he did, would you mind taking over?
> 

Ido sent a patch to take care of it:
https://patchwork.kernel.org/project/netdevbpf/patch/20211124101122.3321496-1-idosch@idosch.org/

Cheers,
 Nik