MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 24 Nov 2021 07:50:20 -0300
From:   Fabio Estevam <festevam@denx.de>
To:     Pavel Machek <pavel@denx.de>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Alagu Sankar <alagusankar@silex-india.com>,
        Erik Stromdahl <erik.stromdahl@gmail.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.10 187/575] ath10k: high latency fixes for beacon buffer
In-Reply-To: <20211116115912.GA24443@amd>
References: <20211115165343.579890274@linuxfoundation.org>
 <20211115165350.173331894@linuxfoundation.org> <20211116115912.GA24443@amd>
Message-ID: <f9a6598c2d6cf80ad40efddba06dddc5@denx.de>
User-Agent: Roundcube Webmail/1.3.6
Precedence: bulk

Hi Pavel,

On 16/11/2021 08:59, Pavel Machek wrote:

> There's GFP_KERNEL vs. GFP_ATOMIC confusion here:
> 
>> @@ -5466,10 +5470,17 @@ static int ath10k_add_interface(struct 
>> ieee80211_hw *hw,
>>  	if (vif->type == NL80211_IFTYPE_ADHOC ||
>>  	    vif->type == NL80211_IFTYPE_MESH_POINT ||
>>  	    vif->type == NL80211_IFTYPE_AP) {
>> -		arvif->beacon_buf = dma_alloc_coherent(ar->dev,
>> -						       IEEE80211_MAX_FRAME_LEN,
>> -						       &arvif->beacon_paddr,
>> -						       GFP_ATOMIC);
>> +		if (ar->bus_param.dev_type == ATH10K_DEV_TYPE_HL) {
>> +			arvif->beacon_buf = kmalloc(IEEE80211_MAX_FRAME_LEN,
>> +						    GFP_KERNEL);
>> +			arvif->beacon_paddr = (dma_addr_t)arvif->beacon_buf;
>> +		} else {
>> +			arvif->beacon_buf =
>> +				dma_alloc_coherent(ar->dev,
>> +						   IEEE80211_MAX_FRAME_LEN,
>> +						   &arvif->beacon_paddr,
>> +						   GFP_ATOMIC);
>> +		}
>>  		if (!arvif->beacon_buf) {
>>  			ret = -ENOMEM;
>>  			ath10k_warn(ar, "failed to allocate beacon
>>  	buffer: %d\n",
> 
> I'd expect both allocations to use same GFP_ flags.

Good catch.

Let me prepare a patch, test it and submit it soon.

Thanks,

Fabio Estevam
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Email: 
festevam@denx.de