Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5379CC43219 for ; Wed, 24 Nov 2021 11:38:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241383AbhKXLl4 (ORCPT ); Wed, 24 Nov 2021 06:41:56 -0500 Received: from mga05.intel.com ([192.55.52.43]:37783 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237708AbhKXLly (ORCPT ); Wed, 24 Nov 2021 06:41:54 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10177"; a="321495484" X-IronPort-AV: E=Sophos;i="5.87,260,1631602800"; d="scan'208";a="321495484" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2021 03:38:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,260,1631602800"; d="scan'208";a="538598992" Received: from irvmail001.ir.intel.com ([10.43.11.63]) by orsmga001.jf.intel.com with ESMTP; 24 Nov 2021 03:38:34 -0800 Received: from newjersey.igk.intel.com (newjersey.igk.intel.com [10.102.20.203]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 1AOBcWOh027559; Wed, 24 Nov 2021 11:38:32 GMT From: Alexander Lobakin To: Vladimir Oltean Cc: Alexander Lobakin , "David S. Miller" , Jakub Kicinski , Jesse Brandeburg , Michal Swiatkowski , Maciej Fijalkowski , Jonathan Corbet , "Shay Agroskin" , Arthur Kiyanovski , "David Arinzon" , Noam Dagan , "Saeed Bishara" , Ioana Ciornei , "Claudiu Manoil" , Tony Nguyen , Thomas Petazzoni , Marcin Wojtas , Russell King , Saeed Mahameed , Leon Romanovsky , Alexei Starovoitov , Daniel Borkmann , "Jesper Dangaard Brouer" , =?iso-8859-1?Q?Toke_H=F8iland-J=F8rgensen?= , John Fastabend , Edward Cree , Martin Habets , "Michael S. Tsirkin" , Jason Wang , "Andrii Nakryiko" , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Lorenzo Bianconi , Yajun Deng , Sergey Ryazanov , David Ahern , Andrei Vagin , Johannes Berg , Cong Wang , "netdev@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "bpf@vger.kernel.org" , "virtualization@lists.linux-foundation.org" Subject: Re: [PATCH v2 net-next 05/26] enetc: implement generic XDP stats callbacks Date: Wed, 24 Nov 2021 12:37:11 +0100 Message-Id: <20211124113711.165114-1-alexandr.lobakin@intel.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211123170920.wgactazyupm32yqu@skbuf> References: <20211123163955.154512-1-alexandr.lobakin@intel.com> <20211123163955.154512-6-alexandr.lobakin@intel.com> <20211123170920.wgactazyupm32yqu@skbuf> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vladimir Oltean Date: Tue, 23 Nov 2021 17:09:20 +0000 > On Tue, Nov 23, 2021 at 05:39:34PM +0100, Alexander Lobakin wrote: > > Similarly to dpaa2, enetc stores 5 per-channel counters for XDP. > > Add necessary callbacks to be able to access them using new generic > > XDP stats infra. > > > > Signed-off-by: Alexander Lobakin > > Reviewed-by: Jesse Brandeburg > > --- > > Reviewed-by: Vladimir Oltean Thanks! > These counters can be dropped from ethtool, nobody depends on having > them there. Got it, thanks. I'll remove them in v3 or, in case v2 gets accepted, will send a follow-up patch(es) for removing redundant Ethtool stats. > Side question: what does "nch" stand for? "The number of channels". I was thinking of an intuitial, but short term, as get_xdp_stats_channels is too long and breaks Tab aligment of tons of net_device_ops across the tree. It was "nqs" /number of queues/ previously, but we usually use term "queue" referring to one-direction ring, in case of these stats and XDP in general "queue pair" or simply "channel" is more correct. Thanks, Al