Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F24E8C433EF for ; Wed, 24 Nov 2021 12:32:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244148AbhKXMfx (ORCPT ); Wed, 24 Nov 2021 07:35:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:49306 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245542AbhKXMaE (ORCPT ); Wed, 24 Nov 2021 07:30:04 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id AFCDC60174; Wed, 24 Nov 2021 12:18:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637756282; bh=hc8sLfcCJ/eMw1NTiu89MqDeLbhOLTcvF8XNjZCyBsU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FVJgeOC3YxyvHYsUMkOF1GVUBDrRcmd3CJoI28IQxS5fECpYHhzM2vncS27BKkhtX 0JHLHUkVaoqdnlDtCRUdJc9KFMJQWaig1gIlAc0aUVeyoM48MJzCPfvS253jIMZK0K FlCvGIOgu+hxQmRDWF/3BuLDt+VLXva2imE5wq5w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dongli Zhang , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 030/251] vmxnet3: do not stop tx queues after netif_device_detach() Date: Wed, 24 Nov 2021 12:54:32 +0100 Message-Id: <20211124115711.289796859@linuxfoundation.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211124115710.214900256@linuxfoundation.org> References: <20211124115710.214900256@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dongli Zhang [ Upstream commit 9159f102402a64ac85e676b75cc1f9c62c5b4b73 ] The netif_device_detach() conditionally stops all tx queues if the queues are running. There is no need to call netif_tx_stop_all_queues() again. Signed-off-by: Dongli Zhang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/vmxnet3/vmxnet3_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index 3628fd7e606fd..98fc34ea78ffe 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -3623,7 +3623,6 @@ vmxnet3_suspend(struct device *device) vmxnet3_free_intr_resources(adapter); netif_device_detach(netdev); - netif_tx_stop_all_queues(netdev); /* Create wake-up filters. */ pmConf = adapter->pm_conf; -- 2.33.0