Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3313C4167B for ; Wed, 24 Nov 2021 12:35:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344813AbhKXMip (ORCPT ); Wed, 24 Nov 2021 07:38:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:48576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343513AbhKXMdW (ORCPT ); Wed, 24 Nov 2021 07:33:22 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D3D94611C1; Wed, 24 Nov 2021 12:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637756428; bh=oehcgmk304cGqbJQRJWFO3w2iPk0lZBUvG+Ct+rgIZk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OjzKEmffb6w9SLdUfcvqb8PUq+llevKdydnwGB78gGNrcG7rekOk0csDxpuCFwL/m jEQrm2eEsfve/lI4KNXSJNR72AA29ojhEZ5rjMWE/iG3cDsD2u3lZ2oSUTH1D9+5GV mbXXk2V+lftIS2IuCRSgXHREDvmaEYd4wMqe/Pzw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, linux-ia64@vger.kernel.org, Andrew Morton , Tony Luck , Chris Down , Paul Gortmaker , John Paul Adrian Glaubitz , Randy Dunlap , Petr Mladek , Sasha Levin Subject: [PATCH 4.14 084/251] ia64: dont do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK Date: Wed, 24 Nov 2021 12:55:26 +0100 Message-Id: <20211124115713.180318441@linuxfoundation.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211124115710.214900256@linuxfoundation.org> References: <20211124115710.214900256@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap [ Upstream commit c15b5fc054c3d6c97e953617605235c5cb8ce979 ] When CONFIG_PRINTK is not set, the CMPXCHG_BUGCHECK() macro calls _printk(), but _printk() is a static inline function, not available as an extern. Since the purpose of the macro is to print the BUGCHECK info, make this config option depend on PRINTK. Fixes multiple occurrences of this build error: ../include/linux/printk.h:208:5: error: static declaration of '_printk' follows non-static declaration 208 | int _printk(const char *s, ...) | ^~~~~~~ In file included from ../arch/ia64/include/asm/cmpxchg.h:5, ../arch/ia64/include/uapi/asm/cmpxchg.h:146:28: note: previous declaration of '_printk' with type 'int(const char *, ...)' 146 | extern int _printk(const char *fmt, ...); Cc: linux-ia64@vger.kernel.org Cc: Andrew Morton Cc: Tony Luck Cc: Chris Down Cc: Paul Gortmaker Cc: John Paul Adrian Glaubitz Signed-off-by: Randy Dunlap Signed-off-by: Petr Mladek Signed-off-by: Sasha Levin --- arch/ia64/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/ia64/Kconfig.debug b/arch/ia64/Kconfig.debug index 677c409425df2..c27c13ca77f47 100644 --- a/arch/ia64/Kconfig.debug +++ b/arch/ia64/Kconfig.debug @@ -42,7 +42,7 @@ config DISABLE_VHPT config IA64_DEBUG_CMPXCHG bool "Turn on compare-and-exchange bug checking (slow!)" - depends on DEBUG_KERNEL + depends on DEBUG_KERNEL && PRINTK help Selecting this option turns on bug checking for the IA-64 compare-and-exchange instructions. This is slow! Itaniums -- 2.33.0