Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC8AC433EF for ; Wed, 24 Nov 2021 12:43:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245465AbhKXMqR (ORCPT ); Wed, 24 Nov 2021 07:46:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:41822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345210AbhKXMlG (ORCPT ); Wed, 24 Nov 2021 07:41:06 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3534F61157; Wed, 24 Nov 2021 12:24:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637756683; bh=J61dc9TsTcoo0CAHf8E/6ahJTkfS1da1aj3CGFpL8yM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2Qv3n6ij/Yy93sIaIm+xGQ/jGuozrylBhsKI7K8Z59vqy74806qOh3V5tiK8ZNnm9 2re0SXTjHalm/Fhl9RQ0ZH4wN2N/ldM2mbiBrLC4SnXbWiGVZzkt4XK9Gr7WwRj03J sVGVbNnQVtVcz9EApUQfMXdMN5MNc4MuPjItNEx0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Evgeny Novikov , Tudor Ambarus , Pratyush Yadav , Sasha Levin Subject: [PATCH 4.14 167/251] mtd: spi-nor: hisi-sfc: Remove excessive clk_disable_unprepare() Date: Wed, 24 Nov 2021 12:56:49 +0100 Message-Id: <20211124115716.072033222@linuxfoundation.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211124115710.214900256@linuxfoundation.org> References: <20211124115710.214900256@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Evgeny Novikov [ Upstream commit 78e4d342187625585932bb437ec26e1060f7fc6f ] hisi_spi_nor_probe() invokes clk_disable_unprepare() on all paths after successful call of clk_prepare_enable(). Besides, the clock is enabled by hispi_spi_nor_prep() and disabled by hispi_spi_nor_unprep(). So at remove time it is not possible to have the clock enabled. The patch removes excessive clk_disable_unprepare() from hisi_spi_nor_remove(). Found by Linux Driver Verification project (linuxtesting.org). Fixes: e523f11141bd ("mtd: spi-nor: add hisilicon spi-nor flash controller driver") Signed-off-by: Evgeny Novikov Signed-off-by: Tudor Ambarus Reviewed-by: Pratyush Yadav Link: https://lore.kernel.org/r/20210709144529.31379-1-novikov@ispras.ru Signed-off-by: Sasha Levin --- drivers/mtd/spi-nor/hisi-sfc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mtd/spi-nor/hisi-sfc.c b/drivers/mtd/spi-nor/hisi-sfc.c index 9209d225e3152..e84a310dcc6cb 100644 --- a/drivers/mtd/spi-nor/hisi-sfc.c +++ b/drivers/mtd/spi-nor/hisi-sfc.c @@ -485,7 +485,6 @@ static int hisi_spi_nor_remove(struct platform_device *pdev) hisi_spi_nor_unregister_all(host); mutex_destroy(&host->lock); - clk_disable_unprepare(host->clk); return 0; } -- 2.33.0