Date:   Wed, 24 Nov 2021 15:43:13 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Todd Kjos <tkjos@google.com>
Cc:     gregkh@linuxfoundation.org, christian@brauner.io, arve@android.com,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        maco@google.com, joel@joelfernandes.org, kernel-team@android.com
Subject: Re: [PATCH 3/3] binder: defer copies of pre-patched txn data
Message-ID: <20211124124313.GH6514@kadam>
References: <20211123191737.1296541-1-tkjos@google.com>
 <20211123191737.1296541-4-tkjos@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211123191737.1296541-4-tkjos@google.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4oGq9YMj4NJjScWJpq3qfhg7ZdjVRWdAPMjulzR4S0pt9SSM0UYTMsvLkxWW?=
 =?us-ascii?Q?uCyRzWxmV3M7ebAx5JSsgzhAjVR+iujjfSnTRpzfsoYIsiqo3EXT6ikD0pfj?=
 =?us-ascii?Q?vfxN1Ha0IdlH4Pr1U8k+9XoEs2xeKThQyw29s/qMGgtB7d4thJ76fB9O5PmL?=
 =?us-ascii?Q?1zTtySq7EYdFpLvOzYUCcX9Fj/di1wIXqRBNs1WuLPXvwtdM1JAPehL+vGvI?=
 =?us-ascii?Q?4a4XhkXRsyObSI/cyqVOA2dBRZWF3IuqnVjl5RuaSIjhK72ZxP5tvampr9hj?=
 =?us-ascii?Q?iYkda05D27/nFAkHblkui4nEOvRq+A8L4/Y/SYcmK73MynVk7Yiu3IybpY9+?=
 =?us-ascii?Q?NSNyvyauyZVWh8DtnqlaL+gXiQ1iEY661G0bPtF331e4DPonwalAYBe4TUu3?=
 =?us-ascii?Q?PrdhD3C7fXNhsuaVTNSnthIeh7YJWYrzRBX4gmwQ7l+FOQGAYw0Zwa+5NJ3m?=
 =?us-ascii?Q?OYjvN80HSPd6ytRg7rP59tCsZgVgKkuFqEcQAvqPcDWmokG3sRZFZr92EXo7?=
 =?us-ascii?Q?0yNhwsjkEe89mmcGGg3Q/AsOJ3O3y1Ob4oBQKU/PbFczbBbMvgQzsh1P2Nsa?=
 =?us-ascii?Q?VjJu5ZzwXO7TJw+CrOgj0Hg4/Cb3vpW1y/kfOiH8MyRUpDzJ45oKVaEKXt5G?=
 =?us-ascii?Q?xvbhsns+m4/WD/oF20fi0lDdAVatJhXt0Kz9Ccz1us1vGbLQAMY4l4c1BsRU?=
 =?us-ascii?Q?zHdRtpK5yUplD3dL/Y5sbxNvAMHxXRSVlQCiW11tro56TJpbmJWtyRiEbDj4?=
 =?us-ascii?Q?ysg5AYUzkTwQPADb2Y5Ob8bYFab+dQrGKlQGov/vu7DaPJskinVT300/DDhJ?=
 =?us-ascii?Q?d4EKxj/mSKBDJZZSKcSYOiY/G2j6PKBruUPiihQd4NMho0GM/CvmF2rgsjLb?=
 =?us-ascii?Q?qDp3wAPsf83JG9BSZYZbdXHLzes1AjZ9gxrxFJ92biFFfMQCl+SGnBFw6aTQ?=
 =?us-ascii?Q?PCmoFDwimgrvP1vf+b9+vzsjqVU98IZq4f5xfAQozbHl68o2K/LgLnhQP3My?=
 =?us-ascii?Q?ICWM7COonULkZU9BmdEvsS2ruf5t22SOpbJVxUaTYuY1E3C6Ju1cAsaeSXAW?=
 =?us-ascii?Q?WE8v0N2tU53O12CMnTmbd2vUatz2e8j/zEl5UE8aINH9IBd/11UxXVdiFCIx?=
 =?us-ascii?Q?wOym5222s2sWzny5aFZNUQ8q3yQXpZz5vdLUKXuRue4/q4SEz4Ixl3z5Pmi1?=
 =?us-ascii?Q?S0eZ6FyVa/OmOxdCz0+j7BNgUbJzWmVcTUegsxmMOUtNQ6zwzCf/6x+SWGJC?=
 =?us-ascii?Q?oHtQLJ0lGM+EGwItzZowo7LiySEDJb1GLFvRPZ93w4S23RLY/xSxVbnSmgkf?=
 =?us-ascii?Q?coq9GCSE1RCKrm+fmgmnIsIj4UPMLGdFOp2NbmMjWvcDVp7jOHtThIMCh+38?=
 =?us-ascii?Q?NhqGChn3Wv3qaYpMahq0y3r6vQx1pRbRLu1/8Y/pxWTHTp6xaO7uPDtL62Wr?=
 =?us-ascii?Q?JOMDhsAEPYUPH4RraNUmhw/grx26qXEFyHLwNsZ2BWAj/bfAuQJB6l0UOMQ9?=
 =?us-ascii?Q?DLqT2XaDed4oN0WPN53M/KOe5pjjsaQ2c8pQXt7UucYBwmJb0chU7S7VGudf?=
 =?us-ascii?Q?p5EIryVmy1dKvYelsnGl4mUTZI5/yqAXTv46h8hmoBywRb/qLBh0KvTWLSVp?=
 =?us-ascii?Q?x7IYHLVZeub7vPiXN93N/zz/E/Wf4fhFKAjVAoFGBhOdUcykSedN4suruOIO?=
 =?us-ascii?Q?lvGQn/oQ3nB++bZwclYm3Qb1t1E=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53352a7a-7be6-42a8-2556-08d9af4807b7
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2021 12:43:35.6332
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9M1oTZFuKEX+hWy2xn36zSxUK/u3G692wVYdndq01IFRzoxr2djkvHjvWsk0AlEgD51aM0ckAmTsS4vvHRu0gVhLCAbqyCcQO/3Y5/UTvtc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2256
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10177 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 spamscore=0
 bulkscore=0 suspectscore=0 mlxscore=0 mlxlogscore=872 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111240071
X-Proofpoint-GUID: e4aixtxB-8ByQd1qxuKkf6Aaz1E1-Z-P
X-Proofpoint-ORIG-GUID: e4aixtxB-8ByQd1qxuKkf6Aaz1E1-Z-P
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 23, 2021 at 11:17:37AM -0800, Todd Kjos wrote:
> +static int binder_do_deferred_txn_copies(struct binder_alloc *alloc,
> +					 struct binder_buffer *buffer,
> +					 struct list_head *sgc_head,
> +					 struct list_head *pf_head)
> +{
> +	int ret = 0;
> +	struct list_head *entry, *tmp;
> +	struct binder_ptr_fixup *pf =
> +		list_first_entry_or_null(pf_head, struct binder_ptr_fixup,
> +					 node);
> +
> +	list_for_each_safe(entry, tmp, sgc_head) {
        ^^^^^^^^^^^^^^^^^^^
All the list_for_each() loops can be changed to list_for_each_entry().


	list_for_each_entry_safe(sgc, tmp, sgc_head, node) {

regards,
dan carpenter


> +		size_t bytes_copied = 0;
> +		struct binder_sg_copy *sgc =
> +			container_of(entry, struct binder_sg_copy, node);
> +