Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E241AC433EF for ; Wed, 24 Nov 2021 13:34:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350430AbhKXNhx (ORCPT ); Wed, 24 Nov 2021 08:37:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:55788 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352302AbhKXNfh (ORCPT ); Wed, 24 Nov 2021 08:35:37 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 23EE36162E; Wed, 24 Nov 2021 12:54:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637758484; bh=zQnaiCykLTZa/TY7dGkINKKGRpLLkoVfpGrmrSqzK8g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OdYLDghJsHgH4J9UfK9v/LvcYUHvg15EiupJGHlHL2n9yKDwTjgPAmQFy3bkK+zPy GCUpreP5em4/OcpXVn/y1u1wLRNEcFi3zyX2YIE/uoRCUlTPc+yI5pZyGADff31FWn 3JZmlk43TUQDp+gE02YnKxLWTXFl1fhcFLM+i7EU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Surabhi Boob , Tony Brelinski , Tony Nguyen , Sasha Levin Subject: [PATCH 5.10 086/154] iavf: Fix for the false positive ASQ/ARQ errors while issuing VF reset Date: Wed, 24 Nov 2021 12:58:02 +0100 Message-Id: <20211124115705.096864441@linuxfoundation.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20211124115702.361983534@linuxfoundation.org> References: <20211124115702.361983534@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Surabhi Boob [ Upstream commit 321421b57a12e933f92b228e0e6d0b2c6541f41d ] While issuing VF Reset from the guest OS, the VF driver prints logs about critical / Overflow error detection. This is not an actual error since the VF_MBX_ARQLEN register is set to all FF's for a short period of time and the VF would catch the bits set if it was reading the register during that spike of time. This patch introduces an additional check to ignore this condition since the VF is in reset. Fixes: 19b73d8efaa4 ("i40evf: Add additional check for reset") Signed-off-by: Surabhi Boob Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c index 90a9379b4e467..643679cad8657 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_main.c +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c @@ -2329,7 +2329,7 @@ static void iavf_adminq_task(struct work_struct *work) /* check for error indications */ val = rd32(hw, hw->aq.arq.len); - if (val == 0xdeadbeef) /* indicates device in reset */ + if (val == 0xdeadbeef || val == 0xffffffff) /* device in reset */ goto freedom; oldval = val; if (val & IAVF_VF_ARQLEN1_ARQVFE_MASK) { -- 2.33.0