DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=GZJRdz8I5RqPOtJ58eHVQB/YisMhXMjIwkMeBaFdRljOTK7h6lSMTjF4NEoubyk13Bub32PZVLUGry5YvODWMsBDobpoGogeRbvtz4yWZcsITVVFVhm5gWHFIq7Bhb8Q/8oaemFbOPC4LnjXYEo8zjs27KybOCkq6wNbJfc0ZXU=
Message-ID: <21d7e9970701141131n24bb371di2c941c681b4afdf8@mail.gmail.com>
Date: Mon, 15 Jan 2007 06:31:01 +1100
From: "Dave Airlie" <airlied@gmail.com>
To: "Arjan van de Ven" <arjan@infradead.org>
Subject: Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros
Cc: "Ahmed S. Darwish" <darwish.07@gmail.com>, jgarzik@pobox.com,
       linux-kernel@vger.kernel.org
In-Reply-To: <1168796241.3123.954.camel@laptopd505.fenrus.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20070114172421.GA3874@Ahmed>
	 <1168796241.3123.954.camel@laptopd505.fenrus.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 859
Lines: 24

On 1/15/07, Arjan van de Ven <arjan@infradead.org> wrote:
> On Sun, 2007-01-14 at 19:24 +0200, Ahmed S. Darwish wrote:
> > Substitue intel_rng magic PCI IDs values used in the IDs table
> > with the macros defined in pci_ids.h
> >
> Hi,
>
>
> hmm this is actually the opposite direction than most of the kernel is
> heading in, mostly because the pci_ids.h file is a major maintenance
> pain.
>
> Afaik the current "rule" is: if a PCI ID is only used in one driver, use
> the numeric value and not (add) a symbolic constant.
>

My guess is that the RNG is on the LPC so the values are used in a few places..

Dave.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/