MIME-Version: 1.0
References: <20211123191737.1296541-1-tkjos@google.com> <YZ3y/aYUeC5HSXk0@kroah.com>
In-Reply-To: <YZ3y/aYUeC5HSXk0@kroah.com>
From:   Todd Kjos <tkjos@google.com>
Date:   Wed, 24 Nov 2021 07:54:15 -0800
Message-ID: <CAHRSSEy527aTTHGeQxD2OiagxTtmyV2kZ5Rfh8JxWA84LxYT-Q@mail.gmail.com>
Subject: Re: [PATCH 0/3] binder: Prevent untranslated sender data from being
 copied to target
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     christian@brauner.io, arve@android.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, maco@google.com,
        joel@joelfernandes.org, kernel-team@android.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Nov 24, 2021 at 12:08 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Nov 23, 2021 at 11:17:34AM -0800, Todd Kjos wrote:
> > Binder copies transactions directly from the sender buffer
> > to the target buffer and then fixes up BINDER_TYPE_PTR and
> > BINDER_TYPE_FDA objects. This means there is a brief time
> > when sender pointers and fds are visible to the target
> > process.
> >
> > This series reworks the the sender to target copy to
> > avoid leaking any untranslated sender data from being
> > visible in the target.
> >
> > Todd Kjos (3):
> >   binder: defer copies of pre-patched txn data
> >   binder: read pre-translated fds from sender buffer
> >   binder: avoid potential data leakage when copying txn
> >
> >  drivers/android/binder.c | 442 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------
> >  1 file changed, 387 insertions(+), 55 deletions(-)
>
> Are these changes needed now in 5.16-final and also in stable kernels?
>
> Or can they wait until 5.17-rc1?

They can wait until 5.17-rc1.

>
> thanks,
>
> greg k-h