Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DD16C433F5 for ; Wed, 24 Nov 2021 16:34:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349070AbhKXQh5 (ORCPT ); Wed, 24 Nov 2021 11:37:57 -0500 Received: from 8bytes.org ([81.169.241.247]:59474 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349029AbhKXQh4 (ORCPT ); Wed, 24 Nov 2021 11:37:56 -0500 Received: by theia.8bytes.org (Postfix, from userid 1000) id 6B7A9341; Wed, 24 Nov 2021 17:34:44 +0100 (CET) Date: Wed, 24 Nov 2021 17:34:35 +0100 From: Joerg Roedel To: Alex Bee Cc: Will Deacon , Heiko Stuebner , Benjamin Gaignard , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/rockchip: Fix PAGE_DESC_HI_MASKs for RK3568 Message-ID: References: <20211124021325.858139-1-knaerzche@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211124021325.858139-1-knaerzche@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 24, 2021 at 03:13:25AM +0100, Alex Bee wrote: > With the submission of iommu driver for RK3568 a subtle bug was > introduced: PAGE_DESC_HI_MASK1 and PAGE_DESC_HI_MASK2 have to be > the other way arround - that leads to random errors, especially when > addresses beyond 32 bit are used. > > Fix it. > > Fixes: c55356c534aa ("iommu: rockchip: Add support for iommu v2") > Signed-off-by: Alex Bee Applied for v5.16, thanks.