Subject: Re: [PATCH] drm/amd/display: Fix warning comparing pointer to 0
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        harry.wentland@amd.com
Cc:     sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <1637749236-27107-1-git-send-email-jiapeng.chong@linux.alibaba.com>
From:   Rodrigo Siqueira Jordao <rjordrigo@amd.com>
Message-ID: <5be550b1-361f-1028-764c-62020e1f23ac@amd.com>
Date:   Wed, 24 Nov 2021 14:40:34 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <1637749236-27107-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTNLM2k1b0hEL054aVFtTkpVbnRDaW1jRVVjMng5Z3ZQUXl4emhncGRQc1Rt?=
 =?utf-8?B?Y1l6blQwaHFZN2dhWkk5cjN6bXlmd0djRm1ic0hHUkNLQjlTdTB4S1d6djZR?=
 =?utf-8?B?VlZjYUxwTUZyU1UyUzRtTmFLN1JGREhiaGg1RHQ5UGprUWxqb0Y2ZjVTaWY0?=
 =?utf-8?B?eEtIOE9LM05qWXkzOU8wemJ3Wlh1K1JEeTF1Y2xKbUNjMVErdGR2ZWs5b2FJ?=
 =?utf-8?B?Vnd6eUVPa3ZpbzZPaHZTQk0vVlE3L3VRTmgyWjhVVVFZaGZzOEhRcUhqSzY2?=
 =?utf-8?B?aEdHbFRCc1I5R0JwOGZXa21DcGJWaDJzMFJoK3pkNWVqMWJWWElQdnBNWFo4?=
 =?utf-8?B?Y1hZMUxONTFEeWpGSUdlVVkwQ2VvZUNPazMydDNldzlsWVI0dVlqR1dBRDZ4?=
 =?utf-8?B?Mnkvb3dEYytEREhsUVlCeFUyVjNOYm5POFZjaHBlQlFCSlRLZ1dxZERXQXBQ?=
 =?utf-8?B?MG82TE8xdzc3VEtHeTZBaXpFT2xEWnlYM0pja0RtRWpqTHUzNStjREY5ZGsw?=
 =?utf-8?B?OTN5cWlYY0tWZEl0SUYwWEpVL0Jabk5BbXJnaXpkVVVISmNiVk1DNFhQYTh3?=
 =?utf-8?B?T2xBaU1VSitRL3cvaWhCalpiUnRKZktnaDM5c0M1ZUJ5elBWQ3BoRlBiNHli?=
 =?utf-8?B?bVBSNnA5dzNrUXhrOGQxVDlSVkZQNlBwOGRPeXdwNmpDakhKendJbHVnM2tD?=
 =?utf-8?B?TXkyZXJDNC9TUlQ2NW15SmI4MHZhaXlQckxQV0tiOTlSR01wMTl4UlpST2p6?=
 =?utf-8?B?d0o1aE1HSllFOHlEMGVuTnAySVVLakxKbHprT0Q5MWdGUE5KdzdxY0IyS2hP?=
 =?utf-8?B?em1IYm53RXBxZ2k0Rks5YTQwWStRTEk1c05mcEdodEVkZWtoUUswdHlmOTBk?=
 =?utf-8?B?YWpNRWdydVBnWFc1SUplc0FsUTMyN3JDVzZvNStmd0JMa0wzV1VFbTF3MkJM?=
 =?utf-8?B?N282bklUTk1PeW1JaENGZ2xFYmd1a0w1N05HS1VSNDYyWXBuejQ4bjcxLzEw?=
 =?utf-8?B?ZW8yU3VYQkRRN2U0NWRFVHJBNjRkdXBIalFlMko4dkhKZXExSjU0cm5vUkdt?=
 =?utf-8?B?bVZyN1RJZ2hwcjFLdlMwS0s0U3huOHZXRXJ1bmtEQ1dyWHQzb2ZkWUs2MWNH?=
 =?utf-8?B?eXgyc3Y4NU5zelo3aEV3YzNPN2ZVWHpONmNhYkNreEt3bG5IdnBtMlBzU3ZU?=
 =?utf-8?B?bW9FcDZ5UFNnaTA5QUtKUTFlME9wTzNkNnNPSW1WRjlIK2w3NXRTVnc0Q1kw?=
 =?utf-8?B?M2hscUVSekJHOXhuK2tyclhmd096UmlydjJlTElHMDJRZW4vUFZwaW1KamZv?=
 =?utf-8?B?dUtDR3NMaGZ1RHBKWWloaVhmbnBRRzBJUUliNmRzZVJZcVUwdGtlc2ZyRTNs?=
 =?utf-8?B?MTd3WFBJWjdjbTlWczV6UG1zRjNrbzI3T3NUdVNmM2paYVd6eS9JL3lXcjlD?=
 =?utf-8?B?Vm5hZ09HRkpRRDdZbmc4dXpNd0FQOWZmRzBxam9tWEd2RjY2ekV3Sm1DcFQ0?=
 =?utf-8?B?T3V3MTQ0UDB3SEtSY1ZlNkFXbUJ3WFZKSDZvaFp1bDVhbnNFK2NzR0V1OC9y?=
 =?utf-8?B?VHdqVHRVSkhiN3VqZmJ4bTdvb3FjNmFhWHYvZFN0cDd6STdNQ2NjY2s1WHBW?=
 =?utf-8?B?MFY1RTVZQnJHdk5rb0JVM2lXbXJqaTlHN0RqOWxXSlUzQzR5Wm4xNTM3RHZl?=
 =?utf-8?B?dURDZGI1MVk3eEt4cW1tdGxtWXZSUmxlaHBuanJIbENvN2h6bVlHYVlqek03?=
 =?utf-8?B?Ym1sa3FTSHBYTUs3Ym9HS3NQOTNEQnJYSHE2YTBaUUVYTmUxbDJUdW1yM0lj?=
 =?utf-8?B?eFV4dnNhN3hwV1RmcUdYR1VvZzVpYU5tS1BlT2VBWmdSazZnN3J2a21kY05s?=
 =?utf-8?B?MHl6MThQVFE3eTRWNGN1V3dzWUR0cHFTVXZua0JiOUxSRVV4Y3JabC8yWXpV?=
 =?utf-8?B?R0VNKzZMNStvT1B5UTBkb0xzSE15aUdyZEhjUHJSZjZkTU9saS9GdU1RbTVv?=
 =?utf-8?B?OVA4Y0kxSUdrS25TN2tJUHU1V0kzVy9IcW15QTU0UExnMzZ2TVNBS3JLNnZi?=
 =?utf-8?B?M3NPUTJyWmovOFJnTDNoUFFzbDdKT3V0TGdPM1Y4bjBZNmJReXVVbmpad2pM?=
 =?utf-8?B?aGIydGYvenhFSlhxL05Nd0lKcERrRTAwdTZIN1BOOExndCtUM3MydWcxbDJo?=
 =?utf-8?B?SVczdTg0Rm5zRW90d1RKa1ptWVRCTTlFR2RQWEZGOXl3YVE5WCtZdVJtOUg2?=
 =?utf-8?Q?xXzvAtjsgUqqf0fRSWo5Go3rx77OF5OrG3pJh6rAcY=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18625548-cde6-4509-236e-08d9af8249d7
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB5564.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2021 19:40:37.1560
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mIbhENKXYhGqkDwwDHMXNxNFNJFhmGUFKA08XNqIQmTmndob2Rzh7nPR3uV+PXjW1JqifNmJK0C7YJsl2Y3NuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5564
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2021-11-24 5:20 a.m., Jiapeng Chong wrote:
> Fix the following coccicheck warning:
> 
> ./drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c:96:14-15: WARNING
> comparing pointer to 0.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c
> index 122ba29..ec636d0 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c
> @@ -93,7 +93,7 @@ static void get_qp_set(qp_set qps, enum colour_mode cm, enum bits_per_comp bpc,
>   		TABLE_CASE(420, 12, min);
>   	}
>   
> -	if (table == 0)
> +	if (!table)
>   		return;
>   
>   	index = (bpp - table[0].bpp) * 2;
> 

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

Applied to amd-staging-drm-next

Thanks