Date:   Wed, 24 Nov 2021 21:06:05 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [GIT PULL] tracing/uprobe: Fix uprobe_perf_open probes iteration
Message-ID: <YZ6bLc81ZBeRUG+U@krava>
References: <20211124100956.6905a198@gandalf.local.home>
 <CAHk-=wjakjw6-rDzDDBsuMoDCqd+9ogifR_EE1F0K-jYek1CdA@mail.gmail.com>
 <CAHk-=whYWvdKrFY3-xcRFqyxAMnhMGsmU=0gYWYWuRrR7mFV-A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHk-=whYWvdKrFY3-xcRFqyxAMnhMGsmU=0gYWYWuRrR7mFV-A@mail.gmail.com>
Precedence: bulk

On Wed, Nov 24, 2021 at 10:30:24AM -0800, Linus Torvalds wrote:
> On Wed, Nov 24, 2021 at 10:27 AM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Instead, you should do something like
> >
> >         list_for_each_entry(pu, trace_probe_probe_list(tp), tp.list) {
> 
> That 'pu' is a typo, it should be 'tu'.
> 
> The patch itself got it right, I think.
> 
> HOWEVER. Despite the patch itself getting it right, I want to point
> out that that was mostly by luck than anything else.
> 
> The patch is ENTIRELY UNTESTED.

I put your patch to the test and.. it passed ;-)

there are several other places like this around and also in trace_kprobe.c
I can send the follow up fix tomorrow

thanks,
jirka

> 
> Because that's how I roll, as you should all know by now.
> 
>                   Linus
>