MIME-Version: 1.0
References: <1637721384-70836-1-git-send-email-yang.lee@linux.alibaba.com> <1637721384-70836-2-git-send-email-yang.lee@linux.alibaba.com>
In-Reply-To: <1637721384-70836-2-git-send-email-yang.lee@linux.alibaba.com>
From:   Gerhard Engleder <gerhard@engleder-embedded.com>
Date:   Wed, 24 Nov 2021 21:32:27 +0100
Message-ID: <CANr-f5yDK=voAX3q6S8dEz=wPBa78QaWVrVctx+YmXFz+oV7OQ@mail.gmail.com>
Subject: Re: [PATCH -next 2/2] tsnep: fix platform_no_drv_owner.cocci warning
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     David Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        netdev <netdev@vger.kernel.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

>
> Remove .owner field if calls are used which set it automatically
>
> Eliminate the following coccicheck warning:
> ./drivers/net/ethernet/engleder/tsnep_main.c:1263:3-8: No need to set
> .owner here. The core will do it.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/net/ethernet/engleder/tsnep_main.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c
> index c48e8ea..3d0408e 100644
> --- a/drivers/net/ethernet/engleder/tsnep_main.c
> +++ b/drivers/net/ethernet/engleder/tsnep_main.c
> @@ -1260,7 +1260,6 @@ static int tsnep_remove(struct platform_device *pdev)
>  static struct platform_driver tsnep_driver = {
>         .driver = {
>                 .name = TSNEP,
> -               .owner = THIS_MODULE,
>                 .of_match_table = of_match_ptr(tsnep_of_match),
>         },
>         .probe = tsnep_probe,
> --
> 1.8.3.1
>

Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>