From:   Peng Fan <peng.fan@nxp.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        Jassi Brar <jassisinghbrar@gmail.com>
CC:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH] mailbox: imx: Fix an IS_ERR() vs NULL bug
Thread-Topic: [PATCH] mailbox: imx: Fix an IS_ERR() vs NULL bug
Thread-Index: AQHX4ULbPmzdSb+TpEijaM96T42qk6wTY+EA
Date:   Thu, 25 Nov 2021 00:27:40 +0000
Message-ID: <DU0PR04MB9417AC0DD29F7610DE794C0688629@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20211124145126.GC13656@kili>
In-Reply-To: <20211124145126.GC13656@kili>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pdmUxXtdbgqjBFe2ywCrrtdSr693L+GB+LZWux0pAfDd6YRQQZPAZkW9iwxJ?=
 =?us-ascii?Q?+L4Cih6OLT83KcCxtEqx4jqPhD/tw4BEUxSuy+GGbbOyyfMG8qnzwzmXPtfQ?=
 =?us-ascii?Q?ds58pm2i34chpSXQcpDA0cPqr9A/yTHqizvRIdR8mAx/MLR4GHtUIg5qlQVH?=
 =?us-ascii?Q?vyoG+NznokyJc06qeZgROFpqefdhKXfGD8n+F0M5/lztqsqPqR24CCxqE7Gw?=
 =?us-ascii?Q?ZoQewNOxe4lfiffrxFdh9p3d6Wf3ZVlF/PzArJZA9h5xLphPuQFWWH6n8gSk?=
 =?us-ascii?Q?rb6c5aR3Amc7pdMJj5Esvq3pUfGyyYNnVD+iVifWVMbjNI3dsnPuYcFhie9q?=
 =?us-ascii?Q?oj8d7GWl2QFSeVVPXJD34ShG/dUsltzO2CVZZTNmEp4GSVfBJwLI/RvvpsKy?=
 =?us-ascii?Q?gTGekgA7zRCV+pVwyhak2pNWHPAPR8o4oiwFj3JGyhCIcx9YJfj8Tyr/0Sc3?=
 =?us-ascii?Q?a9t+ZrGDHPzXJbd9OdGYrfViqvQQjufbMKb06bn8Glv9JpxxMu44er9mugq/?=
 =?us-ascii?Q?N8j46/vHm4BBVqnXmENBKFgdhM3cMkTde5SnlcQEryXCA9lC1GP+sRagScVz?=
 =?us-ascii?Q?+/BVWjIpg/IaIu2LHe1pvjKzPmDAjdfsdU1eUrJJnX7f7Cz/Sk1I9EnTDUzk?=
 =?us-ascii?Q?zdAA/oZJ5nreu4Qj0vKhqr+IwdJUCLELbVVtT6PV5lsBfAYD1mxUQGTD8eN5?=
 =?us-ascii?Q?8ZLQWVMP1jV+J2VhIIe8iIEyeO0065YASwS9euQVebZnudc7Ve2FWhDgiOG/?=
 =?us-ascii?Q?ws+LLQ/2dV5NgGO7pwN7LLWeS+BJYU8EBPeu8VOsmn5iSTNIaEfgnoTSwXeJ?=
 =?us-ascii?Q?bsjnmVsMItaufI+0JprmvVGujH5PE6kb7JPyr1k0TlztsZIx9YdrHhP2GOWf?=
 =?us-ascii?Q?FHF24dLPG4GgDCd+YBGzl8xBT2zJ1ypnS2A6cuLu6SfsE4LNCbw5JdukRuzy?=
 =?us-ascii?Q?XtGIRb4NS107sx7CjK/7aQGYobjERVTSwWiCHgLghW6D38GZHI4Sl4oOnkfn?=
 =?us-ascii?Q?neDlFkrey8L8tPSZUmeqtOBhKiLl/JtjHUTRhuic6UqFzmWT9PDQ48j8hO4I?=
 =?us-ascii?Q?E6n4bpy2Q5Ta3pBb8sRsVPA3p2KpPtwG5ztyUrHok7/WMYbZT61ch8344TgV?=
 =?us-ascii?Q?891YEGYIIJKFdNSo2DaD7CWfjFqc9v5+hS8doYiskJlR1SXBkKkinI6C7d9H?=
 =?us-ascii?Q?E2xO/oDqMupYfaTL6lsxG1Hb+thlHbE0VYOciSwlNECC56h5OYRySM5BjX5i?=
 =?us-ascii?Q?SmJz4B/mzTtlyrlrcZ3F7lQ5xsnYo089h81wuX4pEG4Jdde6wNli6f0D6Zj+?=
 =?us-ascii?Q?h26o3zQFKX7jFlXTx7tQB6ZjtP/4v8mGuFV6eZcTrgphiDM/G3UDdfJpxa/w?=
 =?us-ascii?Q?YoA/BjdjZFkUMNb58pWgQHb2qU618RGcC6DKdmLdERMD0EsbiPto7xoJjscw?=
 =?us-ascii?Q?GdNV+U/QTNoLj1Pn9j5z+t4XuLWjgQeoVpFFwPvGfyWw/OWRjGxkeJj48v6d?=
 =?us-ascii?Q?triIRP2OV1cfgF9D+i5XxhGoA9LJw/F3znQyAc6FOzE/wjYx8gPpYN10E4mU?=
 =?us-ascii?Q?mrbC2kBpAuCleQXc+oqws2I1Hls1mIFb7+n5lHXOlBnSdKOffBebJw6Po9bP?=
 =?us-ascii?Q?h5bghkJUOcZoh5DGihHK2lk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2778bdd-5c1d-41e5-2ce5-08d9afaa63eb
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2021 00:27:40.4069
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8/ryocoXeDMQTXy8is1DH6ku+CScONN3bXqIm4x04KBLSWFuL6OJbk+XbpPlENzme+r4q0mA0FAajMa7GR081w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8478
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH] mailbox: imx: Fix an IS_ERR() vs NULL bug
>=20
> The devm_kzalloc() function does not return error pointers, it returns NU=
LL on
> failure.
>=20
> Fixes: 97961f78e8bc ("mailbox: imx: support i.MX8ULP S4 MU")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  drivers/mailbox/imx-mailbox.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.=
c
> index ffe36a6bef9e..544de2db6453 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -563,8 +563,8 @@ static int imx_mu_probe(struct platform_device
> *pdev)
>  		size =3D sizeof(struct imx_sc_rpc_msg_max);
>=20
>  	priv->msg =3D devm_kzalloc(dev, size, GFP_KERNEL);
> -	if (IS_ERR(priv->msg))
> -		return PTR_ERR(priv->msg);
> +	if (!priv->msg)
> +		return -ENOMEM;
>=20
>  	priv->clk =3D devm_clk_get(dev, NULL);
>  	if (IS_ERR(priv->clk)) {
> --
> 2.20.1