Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16CE1C433EF for ; Thu, 25 Nov 2021 01:11:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347332AbhKYBOw (ORCPT ); Wed, 24 Nov 2021 20:14:52 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:60177 "EHLO wout3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345567AbhKYBMv (ORCPT ); Wed, 24 Nov 2021 20:12:51 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id D4AB53201CD3; Wed, 24 Nov 2021 20:09:39 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 24 Nov 2021 20:09:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=jGPihi 4ljyAa/Ki0//eZ9S9R+JlJhSZ+gF/GSVZZuwo=; b=LSFA+/iTR3YjMYtA2BbTtS PRkSEWiB2o8sIWdBIsWaL7mYe/haIP3RhfAiOlIduPefbZNvTpkbm5PgKzF9Wpdm sN/dL//sGiYv99ByoZb+a5oBQKiMvG71C0lR22Jf6ykMn7g+aCKRh6GF60myooh8 9Aq0y+GMvq4Dovr+0AH21Cmw754JvUgsxhZoNSZxspmOwTKabqxkysifVyC2cDdM x6Ar7ajCRpZN3QiQZMTbh6q+UOzzEDM9WfhhqjMjs1RRqwc7/i40a53h0t96CNWk N+BU2bL4y3ErYJ+X9xSVaPHfK9oX6ijx+dSp5/I8cB9WSndsmWga2U0reu+xe9Hg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgeelgddvkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvufgjkfhfgggtsehttdertddttddvnecuhfhrohhmpefhihhnnhcuvfhh rghinhcuoehfthhhrghinheslhhinhhugidqmheikehkrdhorhhgqeenucggtffrrghtth gvrhhnpeffudfhgeefvdeitedugfelueegheekkeefveffhfeiveetledvhfdtveffteeu udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehfth hhrghinheslhhinhhugidqmheikehkrdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 Nov 2021 20:09:37 -0500 (EST) Date: Thu, 25 Nov 2021 12:09:41 +1100 (AEDT) From: Finn Thain To: Michael Schmitz cc: Damien Le Moal , Bartlomiej Zolnierkiewicz , Jens Axboe , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pata_falcon: Add missing __iomem annotations In-Reply-To: Message-ID: <682664c-836e-ae61-6844-207a980f9cd@linux-m68k.org> References: <44e0213a681f3c8ee4c6ab2ef9d61ce3ac00e368.1637727935.git.fthain@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Nov 2021, Michael Schmitz wrote: > On 24/11/21 17:25, Finn Thain wrote: > > The zero day bot reported some sparse complaints in pata_falcon.c. E.g. > > > > drivers/ata/pata_falcon.c:58:41: warning: cast removes address space > > '__iomem' of expression > > drivers/ata/pata_falcon.c:58:41: warning: incorrect type in argument 1 > > (different address spaces) > > drivers/ata/pata_falcon.c:58:41: expected unsigned short volatile > > [noderef] [usertype] __iomem *port > > drivers/ata/pata_falcon.c:58:41: got unsigned short [usertype] * > > > > The same thing shows up in 8 places, all told. Avoid this by use of > > __iomem type casts. > > Seeing as data_addr was explicitly typed as __iomem, your fix is clearly > correct. Bit embarrassing to have missed that (I remember adding __iomem > annotations elsewhere at some stage). > > If you think there's any need to test this change, say so. > There's no change in pata_falcon.o. > Reviewed-by: Michael Schmitz > Thanks.