Date:   Wed, 24 Nov 2021 19:16:49 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>
Cc:     netdev@vger.kernel.org, Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        Volodymyr Mytnyk <vmytnyk@marvell.com>,
        Taras Chornyi <tchornyi@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-kernel@vger.kernel.org,
        Serhiy Boiko <serhiy.boiko@marvell.com>
Subject: Re: [PATCH net-next 2/3] net: prestera: add counter HW API
Message-ID: <20211124191649.08f7ba14@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <1637686684-2492-3-git-send-email-volodymyr.mytnyk@plvision.eu>
References: <1637686684-2492-1-git-send-email-volodymyr.mytnyk@plvision.eu>
        <1637686684-2492-3-git-send-email-volodymyr.mytnyk@plvision.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 23 Nov 2021 18:58:01 +0200 Volodymyr Mytnyk wrote:
> +	block = prestera_counter_block_lookup_not_full(counter, client);
> +	if (!block) {

if (block)
	return block;

> +		block = kzalloc(sizeof(*block), GFP_KERNEL);
> +		if (!block)
> +			return ERR_PTR(-ENOMEM);
> +
> +		err = prestera_hw_counter_block_get(counter->sw, client,
> +						    &block->id, &block->offset,
> +						    &block->num_counters);
> +		if (err)
> +			goto err_block;
> +
> +		block->stats = kcalloc(block->num_counters,
> +				       sizeof(*block->stats), GFP_KERNEL);
> +		if (!block->stats) {
> +			err = -ENOMEM;
> +			goto err_stats;
> +		}
> +
> +		block->counter_flag = kcalloc(block->num_counters,
> +					      sizeof(*block->counter_flag),
> +					      GFP_KERNEL);
> +		if (!block->counter_flag) {
> +			err = -ENOMEM;
> +			goto err_flag;
> +		}
> +
> +		block->client = client;
> +		mutex_init(&block->mtx);
> +		refcount_set(&block->refcnt, 1);
> +		idr_init_base(&block->counter_idr, block->offset);
> +
> +		err = prestera_counter_block_list_add(counter, block);
> +		if (err)
> +			goto err_list_add;
> +	}
> +
> +	return block;