Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932305AbXAONDj (ORCPT ); Mon, 15 Jan 2007 08:03:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932308AbXAONDj (ORCPT ); Mon, 15 Jan 2007 08:03:39 -0500 Received: from tmailer.gwdg.de ([134.76.10.23]:47550 "EHLO tmailer.gwdg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932305AbXAONDi (ORCPT ); Mon, 15 Jan 2007 08:03:38 -0500 Date: Mon, 15 Jan 2007 14:01:58 +0100 (MET) From: Jan Engelhardt To: Patrick McHardy cc: David Madore , netfilter-devel@lists.netfilter.org, linux-kernel@vger.kernel.org Subject: Re: [patch] netfilter: implement TCPMSS target for IPv6 In-Reply-To: <45AB54E5.6060103@trash.net> Message-ID: References: <20070114192011.GA6270@clipper.ens.fr> <45AB3DCA.9020204@trash.net> <45AB54E5.6060103@trash.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Report: Content analysis: 0.0 points, 6.0 required _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1081 Lines: 31 On Jan 15 2007 11:18, Patrick McHardy wrote: >Jan Engelhardt wrote: >> On Jan 15 2007 09:39, Patrick McHardy wrote: >> >>>I'm not sure how well that will work (the IPv4/IPv6-specific stuff >>>is spread over the entire target function), but its worth a try. >> >> >> well here's a q: would a patch be accepted that changes >> all ipt and ip6t modules to the new xt? Even if a module is only for >> ipv4 or ipv6, I think it makes sense to reduce the number of >> different *t structures floating around. > >If you're talking about using the xt-structures in net/ipv[46]/netfilter >and removing the ipt/ip6t-wrappers, that would make sense IMO. Yup. Should the files then be renamed/moved to net/netfilter/xt_[foobaz].c in a second step? Should I leave ipt_TCPMSS/ip6t_TCPMSS untouched while you are working on that one? -`J' -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/