Date:   Thu, 25 Nov 2021 09:37:38 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Todd Kjos <tkjos@google.com>
Cc:     devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, arve@android.com, maco@google.com,
        joel@joelfernandes.org, kernel-team@android.com,
        christian@brauner.io
Subject: Re: [PATCH 2/3] binder: read pre-translated fds from sender buffer
Message-ID: <20211125063738.GK6514@kadam>
References: <20211123191737.1296541-1-tkjos@google.com>
 <20211123191737.1296541-3-tkjos@google.com>
 <20211124123719.GG6514@kadam>
 <CAHRSSEzj10quNV6mK9QQezPRMyO49xNA14O4wCsx+eY_UkjQWQ@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHRSSEzj10quNV6mK9QQezPRMyO49xNA14O4wCsx+eY_UkjQWQ@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4dSyR7QO3O11HhjEkpYXcqnQkDrvWdeZ9gP7p9x/AGmW+MGmDZQcSyzniSy0?=
 =?us-ascii?Q?Ol0EFUUdBeld7daD12d3mRpwF51B0tIxz2eanEkDJBaaMEdOdg82K6NZRamm?=
 =?us-ascii?Q?AFwIoor5GP2KR2EDoBgVxN2TzTe5phyp0JCRoDy3L7oprcQK5eycuZ19GQKw?=
 =?us-ascii?Q?7bHGgDHiTBlYDZhdGVIGp/KSZPfNy0xoV3tp3zmYVs1IRWNG4AbETYQr7CbK?=
 =?us-ascii?Q?+RjthJQ51qZMgYx5DYi2Cszmclbnd0b7kigTLQ1meYJG77PRPsGNBEGsOp3h?=
 =?us-ascii?Q?zcaXVu81N+s1aeVAFFTHEq9JvNLmdKngKnCrFtGgNDfgn/o0xEol14Wk0xFL?=
 =?us-ascii?Q?WoatIHij5jvDsExU6SiTlAoMwl/augCuFnxLqxHd22xnLjwGZ+OR5ezyfxUS?=
 =?us-ascii?Q?45QqZz2/yfYSqYMGHAqQeCegYRZ1IDy51fHgmRpcCUnHuv1tDOiYLcNQkWhN?=
 =?us-ascii?Q?wD8rCxchLLZkiv6HlirJrPIhiBzx3yImTXz4yt8FvwqRGWLt1Gs0ie/7MmUe?=
 =?us-ascii?Q?lpKSctws4njhY7kcvt5ZuyBL8yS7q0nKd1NePkexeGst+iFjBpc71QdZpzMT?=
 =?us-ascii?Q?vEXfz8ezNMWMA9VSCVwAifn+VP3GUWSqA1znJz9gGKYkWf8dLjObdmossYMX?=
 =?us-ascii?Q?vaxQwwjtmB49gxVGmlvesiF5H/1P9SAaL21EunYK8Fr3Zq7ujd5O2SBN1ofO?=
 =?us-ascii?Q?dS1GN0hjpy4+Yh3EfUx/jho+yGxh7EBj6OnkHY6aK5RCpNvhCJQrobiVw/Td?=
 =?us-ascii?Q?UZ2L1Qpogc+Q1Wm+Hc1lgKkTm/uSUHQgYLwXW9suiXcla6tKX44x+AnuhonJ?=
 =?us-ascii?Q?gxctuoIRuRmwHHqmruJ/56x+uW4wPOxrpLBJV51oaif34gXYKP81RIy/gw3w?=
 =?us-ascii?Q?GxjkX/eK59Alqtj53GHFP7vGLRzIsfUSSqa906wABN3NXYdZiBVG5i7ciOzz?=
 =?us-ascii?Q?Oo/VAARGp0PxeXbA48L5cTdJ4jVG+GH6tmutkIPq4Kb1IF0mr6k3MjOdBhw1?=
 =?us-ascii?Q?0BrF5WEYZH59WbnYTDPb7t55U4JX3NhK9sDsZi57KJCEgGLJbiUwhP4CvYWb?=
 =?us-ascii?Q?fB6vgjbZeiD6oZRraFqTCc2ylIBmJXzfe3pq6GFygrRnsenD9qzv378ksoCX?=
 =?us-ascii?Q?zH4KdVUNI4aORqfGwBu417qrDWL1IxrVYDcqQzuEailiNQlKAY+5W9CyizO3?=
 =?us-ascii?Q?ljhfLs/xqrMgBzBLshNtEFocDWNNBXzw0SMuhpneSAeTa6xT4n1HcnEfpqAF?=
 =?us-ascii?Q?3Nnnji7mZkfdhhX9o7mozl+HCf8tDMzRTon+/1EO3HqiJ41/SGAewyfZPBXv?=
 =?us-ascii?Q?A0PvRwpK970xLcZ9BkesYMx/a6Z9zOgtvt2Bvy+saKGzALbKb2pKzL3D0M3U?=
 =?us-ascii?Q?9/WpnLAAjyWXxxjcQhSLRoTQrMZMBaz6LQKkRxP2rEZg8cczCm5nOsh2I7b0?=
 =?us-ascii?Q?lOv9bWYACqN+AuznyPTJAWYweYd20xEv/ChCBdWxSPoILws4cgaQushNbGor?=
 =?us-ascii?Q?4Pk2M/jGB/GYjT7lGyyBxUsMOqEOcrF/u2AX+3KiScahw7+jwY4sfWm0K0dQ?=
 =?us-ascii?Q?nwiW0GsAP1Z9YMFZ7jrTlzck4PF4tDlgJ2Aiu4B6EgRMk4mLTar/UTmvwqzv?=
 =?us-ascii?Q?GOqD7ejsEA8M6GdzOoFiRDMvgkqQ6+cFr+w3cP7x6AJsS3hNv7WrojOoR8c6?=
 =?us-ascii?Q?TPgiQs/2f3pX++uMrKOR7PRlFbI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94faadd4-fd39-4aba-babc-08d9afde20ff
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2021 06:38:02.4044
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TlbNhS/WTkPnMIRoFtjcBP79192hrRzQb4tnOPJgBf8UXyqmEyWzAAsA8kxdR3oTqbNR7IqGJmpdpionlPpoWdv1RfOC8YlRnjnIJ5pTgaE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1295
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10178 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 mlxscore=0
 bulkscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111250036
X-Proofpoint-ORIG-GUID: 5I-jBMChqq-HKzoY0Nsm0qX0QlaFSfuq
X-Proofpoint-GUID: 5I-jBMChqq-HKzoY0Nsm0qX0QlaFSfuq
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 24, 2021 at 12:33:20PM -0800, Todd Kjos wrote:
> I agree -- if copy_from_user() for some reason doesn't copy the whole
> buffer, it might return a positive integer. Then it would skip
> binder_translate_fd(), but not return. That should probably be
> something like:
> 
>   if (ret)
>     return ret > 0 ? -EINVAL : ret;
> 
> Will fix in next version.

It should really be a separate patch at the start of the series because
it's from the original code and unrelated.

regards,
dan carpenter