Date:   Thu, 25 Nov 2021 10:03:28 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Parav Pandit <parav@nvidia.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org,
        "Michael S. Tsirkin" <mst@redhat.com>, Eli Cohen <elic@nvidia.com>,
        Jason Wang <jasowang@redhat.com>,
        Eric Dumazet <edumazet@google.com>
Subject: drivers/vdpa/vdpa.c:296 vdpa_mgmtdev_fill() warn: should '(((1))) <<
 (mdev->id_table[i]->device)' be a 64 bit type?
Message-ID: <202111250317.VUsGtdox-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?li6OgPymhFrFdz8bBQmn4zEd/EJLTpZCWnXq+AdwjjXSAnyVDPvSR6lHTSn0?=
 =?us-ascii?Q?3oFzIdTM22WvLlqrrUEcw/Mt7Kmj9rJi0A3x0C1yst0Hs8rnnAKFTOwZBguS?=
 =?us-ascii?Q?BoG1zQXBU2zBySScJeAS3MIoJQ7Kucjlpw/K/PlVszTPWZHFr7jBTrfV4zOb?=
 =?us-ascii?Q?Cx0+rh0eLZ4kKl293IGX0JuNYGGqeduAx3Yo8svTxAoF3mRQEsw5vnUG/Ipf?=
 =?us-ascii?Q?czYzxwXDYnQxA9ixTMoOgvRyjkvSHQM086CTtWVlQSnbmbnFTwMoLqOLYZel?=
 =?us-ascii?Q?twI6AkSwh6oXkzQ5Exu7VMQcrdIEzT36NgX9hMVZdyC+ceSiPcIxb3hHjeg2?=
 =?us-ascii?Q?+hE83UCTDl/Z2xnEcvhFlmpnRd0Cpj7vX3X4DSiFjOH0e0H6TmOj1nSX7xGR?=
 =?us-ascii?Q?+lCCebqunhPuku4mXvkabqwKjkW6eLkNmjv2M7kCqs4zEefVSpPmgVdq2XM8?=
 =?us-ascii?Q?tKsYAc/1yhhtTTCHLr8E/g+558idTc1uwUXFT3RQh0WKCiQf2rqz1Jre7Cpw?=
 =?us-ascii?Q?rov8YZM0VsHT7KbPw3C5GVvfB+JLTe0L8URiFh5yWKhm9o6woiz4MX9xAlKg?=
 =?us-ascii?Q?0y54lSpVXn4Ydtll/m3C2Lxcnk//gxaMmbll0wukbEN5pXwJTPD9Z0dySSWu?=
 =?us-ascii?Q?8CtOPLTa1i2jXwhH88c8ojq2NdxlhOf+O8FYXu79A+/AerpUdHiyPo08ELtp?=
 =?us-ascii?Q?8lV8yxV8p+iWLlqHsDGpo6AaMtsMfOYpJdNedrkgaCl59xuBTvMeofAvpcZr?=
 =?us-ascii?Q?eISIvtXxMjblJW4itcA6g1LN6PGLBWaaIvyWh7djKTrGTrej/Gpi6/hgkc1h?=
 =?us-ascii?Q?v8yaI5HhV7VgCrWEfiQMJBWONXayI/mvASB4bqizq8QZIPsmI48Ultc5Fsjq?=
 =?us-ascii?Q?T6rFfuOa13C4iWwoQcQSM83nPE+nEcU3YP4FYtXB4l9Uruz00pRBtRuZxzMB?=
 =?us-ascii?Q?kctRZgMCwWIfxi5Adpb5IOQIn/aC46L8rV222lYI3+BNcO0Dgm6uo+5PUCqu?=
 =?us-ascii?Q?vuTlI6dOd0xRAs7JL1Q0on9PgX5pNR7ig5dqhrMtXaPCYGTrTJk5jSXBdLwK?=
 =?us-ascii?Q?gqyN1yDVUG/yHJ3pVQy/4E4vOisrRs23wlBDp85Ulvusjp3YD4ZCnGjBfhbp?=
 =?us-ascii?Q?ahQQCnaCuGRG6K5/EU5zY5DHWyK8fLYA0g5HTg+a5KUdjLOLL+RKGHNizTTd?=
 =?us-ascii?Q?JlQZbuzQ1Fz5+qHPzKwQ0gPDPLG8esfuJCDmAv0uj4Pb4HXIDFG7CTYcRfY/?=
 =?us-ascii?Q?Rkfnx2wsReQAGBzMOMQU6zT7Rpf0y2b7NGOAK9VsMb+JNGGNR8hyUaBA+Zic?=
 =?us-ascii?Q?grDCzHfgrSasVCSzxIlyBXYgA4PPSh/4bnGPXQRzyt1lwL0is4GCx7GpmLZU?=
 =?us-ascii?Q?Bj5+wquTuwYpkDIDf6HRyUIDjMlutlK6/50c3cYhkOD97srEPXfnItHyfIU9?=
 =?us-ascii?Q?0QCpRvcXcltDpgbkj1SUcCGu5TFoUMAR8MWv6HenmqFzMzRPVdjtaxI3J2We?=
 =?us-ascii?Q?Dlbsd6EVlG6sPnqNdR5bb+HQRF206yXfG5pkuKIjmrgMbndZVxtdQaifceeY?=
 =?us-ascii?Q?JiGboG/dNs69HTv+HlUuhuT3BnqinVsBVkWe66uGrAJqESVyf7+XJjJYqbtM?=
 =?us-ascii?Q?heuNyC4dj9mzYEk8UEZivxMB2sl/AB5CoYwCFD5JExshkbkfh7yBROfUnRZU?=
 =?us-ascii?Q?uMQkbsDgu4EEg05xUdT7xJ6NXC0=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b57538d7-000e-4b43-e88d-08d9afe1b88b
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2021 07:03:45.1603
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GZ78RrgiPZI+axLiI9g8vGOly8Ra1/C/1dk8gnzQ6ieojt/ewj9ZloPBivB5fGZvegZFLzId5dkNABmHvNO6rgfJoegL4M24BzXa0YB2DJU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5459
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10178 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 spamscore=0
 bulkscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111250038
X-Proofpoint-ORIG-GUID: EdEaDJIF7JXkz3MbzP9u_XNgEb7pNXov
X-Proofpoint-GUID: EdEaDJIF7JXkz3MbzP9u_XNgEb7pNXov
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   5d9f4cf36721aba199975a9be7863a3ff5cd4b59
commit: 33b347503f014ebf76257327cbc7001c6b721956 vdpa: Define vdpa mgmt device, ops and a netlink interface
config: i386-randconfig-m021-20211118 (https://download.01.org/0day-ci/archive/20211125/202111250317.VUsGtdox-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/vdpa/vdpa.c:296 vdpa_mgmtdev_fill() warn: should '(((1))) << (mdev->id_table[i]->device)' be a 64 bit type?

vim +296 drivers/vdpa/vdpa.c

33b347503f014eb Parav Pandit 2021-01-05  280  static int vdpa_mgmtdev_fill(const struct vdpa_mgmt_dev *mdev, struct sk_buff *msg,
33b347503f014eb Parav Pandit 2021-01-05  281  			     u32 portid, u32 seq, int flags)
33b347503f014eb Parav Pandit 2021-01-05  282  {
33b347503f014eb Parav Pandit 2021-01-05  283  	u64 supported_classes = 0;
                                                ^^^^^^^^^^^^^^^^^^^^^
This is a u64

33b347503f014eb Parav Pandit 2021-01-05  284  	void *hdr;
33b347503f014eb Parav Pandit 2021-01-05  285  	int i = 0;
33b347503f014eb Parav Pandit 2021-01-05  286  	int err;
33b347503f014eb Parav Pandit 2021-01-05  287  
33b347503f014eb Parav Pandit 2021-01-05  288  	hdr = genlmsg_put(msg, portid, seq, &vdpa_nl_family, flags, VDPA_CMD_MGMTDEV_NEW);
33b347503f014eb Parav Pandit 2021-01-05  289  	if (!hdr)
33b347503f014eb Parav Pandit 2021-01-05  290  		return -EMSGSIZE;
33b347503f014eb Parav Pandit 2021-01-05  291  	err = vdpa_nl_mgmtdev_handle_fill(msg, mdev);
33b347503f014eb Parav Pandit 2021-01-05  292  	if (err)
33b347503f014eb Parav Pandit 2021-01-05  293  		goto msg_err;
33b347503f014eb Parav Pandit 2021-01-05  294  
33b347503f014eb Parav Pandit 2021-01-05  295  	while (mdev->id_table[i].device) {
33b347503f014eb Parav Pandit 2021-01-05 @296  		supported_classes |= BIT(mdev->id_table[i].device);

Which suggests that this should be BIT_ULL().

33b347503f014eb Parav Pandit 2021-01-05  297  		i++;
33b347503f014eb Parav Pandit 2021-01-05  298  	}
33b347503f014eb Parav Pandit 2021-01-05  299  
33b347503f014eb Parav Pandit 2021-01-05  300  	if (nla_put_u64_64bit(msg, VDPA_ATTR_MGMTDEV_SUPPORTED_CLASSES,
33b347503f014eb Parav Pandit 2021-01-05  301  			      supported_classes, VDPA_ATTR_UNSPEC)) {
33b347503f014eb Parav Pandit 2021-01-05  302  		err = -EMSGSIZE;
33b347503f014eb Parav Pandit 2021-01-05  303  		goto msg_err;
33b347503f014eb Parav Pandit 2021-01-05  304  	}
33b347503f014eb Parav Pandit 2021-01-05  305  
33b347503f014eb Parav Pandit 2021-01-05  306  	genlmsg_end(msg, hdr);
33b347503f014eb Parav Pandit 2021-01-05  307  	return 0;
33b347503f014eb Parav Pandit 2021-01-05  308  
33b347503f014eb Parav Pandit 2021-01-05  309  msg_err:
33b347503f014eb Parav Pandit 2021-01-05  310  	genlmsg_cancel(msg, hdr);
33b347503f014eb Parav Pandit 2021-01-05  311  	return err;
33b347503f014eb Parav Pandit 2021-01-05  312  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org