MIME-Version: 1.0
References: <20211103114830.62711-1-alistair@alistair23.me> <20211105155243.7b635651@aktux>
In-Reply-To: <20211105155243.7b635651@aktux>
From:   Alistair Francis <alistair23@gmail.com>
Date:   Thu, 25 Nov 2021 19:44:02 +1000
Message-ID: <CAKmqyKP2ZXtmGGeoVO13E0pJs+TcnC8GigFiKvrEmNjgsutU-w@mail.gmail.com>
Subject: Re: [PATCH v2 0/4] Add support for the Cypress cyttsp5
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     Alistair Francis <alistair@alistair23.me>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        devicetree <devicetree@vger.kernel.org>,
        linux-input <linux-input@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Mylene Josserand <mylene.josserand@free-electrons.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Henrik Rydberg <rydberg@bitmath.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Rob Herring <robh+dt@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Nov 6, 2021 at 12:52 AM Andreas Kemnade <andreas@kemnade.info> wrote:
>
> Hallo Alistair,
>
> my Xorg (debian buster installation) does not like that:
> [  3112.462] (**) cyttsp5: Applying InputClass "evdev touchscreen catchall"
> [  3112.462] (**) cyttsp5: Applying InputClass "libinput touchscreen catchall"
> [  3112.462] (II) Using input driver 'libinput' for 'cyttsp5'
> [  3112.463] (**) cyttsp5: always reports core events
> [  3112.463] (**) Option "Device" "/dev/input/event1"
> [  3112.463] (**) Option "_source" "server/udev"
> [  3112.496] (II) event1  - cyttsp5: is tagged by udev as: Touchscreen
> [  3112.498] (EE) event1  - cyttsp5: kernel bug: device has min == max on ABS_X
> [  3112.498] (II) event1  - cyttsp5: was rejected
> [  3112.498] (II) event1  - not using input device '/dev/input/event1'.
> [  3112.499] (EE) libinput: cyttsp5: Failed to create a device for /dev/input/event1
>
> # evtest /dev/input/event1
> Input driver version is 1.0.1
> Input device ID: bus 0x0 vendor 0x0 product 0x0 version 0x0
> Input device name: "cyttsp5"
> Supported events:
>   Event type 0 (EV_SYN)
>   Event type 1 (EV_KEY)
>     Event code 330 (BTN_TOUCH)
>   Event type 2 (EV_REL)
>   Event type 3 (EV_ABS)
>     Event code 0 (ABS_X)
>       Value      0
>       Min        0
>       Max        0 <-- upsets xorg
>     Event code 1 (ABS_Y)
>       Value      0
>       Min        0
>       Max        0
>     Event code 47 (ABS_MT_SLOT)
>       Value      0
>       Min        0
>       Max       31
>     Event code 48 (ABS_MT_TOUCH_MAJOR)
>       Value      0
>       Min        0
>       Max      255
>     Event code 49 (ABS_MT_TOUCH_MINOR)
>       Value      0
>       Min        0
>       Max      255
>     Event code 53 (ABS_MT_POSITION_X)
>       Value      0
>       Min        0
>       Max     1447
>     Event code 54 (ABS_MT_POSITION_Y)
>       Value      0
>       Min        0
>       Max     1071
>     Event code 57 (ABS_MT_TRACKING_ID)
>       Value      0
>       Min        0
>       Max    65535
>     Event code 58 (ABS_MT_PRESSURE)
>       Value      0
>       Min        0
>       Max      255
>
> I specified touchscreen-size-x and touchscreen-size-y in my devicetree.
> No idea why it is like this yet.

Thanks! I see the same problem on my side as well. I'm not using X so
I don't see a crash and didn't notice the error.

I'll work on fixing this.

Alistair