Date:   Thu, 25 Nov 2021 10:51:50 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Maulik Shah <quic_mkshah@quicinc.com>
Cc:     bjorn.andersson@linaro.org, rafael@kernel.org,
        daniel.lezcano@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        ulf.hansson@linaro.org, quic_lsrao@quicinc.com,
        rnayak@codeaurora.org, Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH] sched/idle: Export cpu_idle_poll_ctrl() symbol
Message-ID: <YZ9ctgCBYJEEjuwt@hirez.programming.kicks-ass.net>
References: <1637831676-32737-1-git-send-email-quic_mkshah@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1637831676-32737-1-git-send-email-quic_mkshah@quicinc.com>
Precedence: bulk

On Thu, Nov 25, 2021 at 02:44:36PM +0530, Maulik Shah wrote:
> Export cpu_idle_poll_ctrl() so that module drivers can use same.

This does not seem like a really safe interface to expose to the
world.

Surely the better solution is to rework things to not rely on this. I'm
fairly sure it's not hard to write a cpuidle driver that does much the
same.