Date:   Thu, 25 Nov 2021 11:48:13 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Martin Kepplinger <martin.kepplinger@puri.sm>
Cc:     sakari.ailus@linux.intel.com, mchehab@kernel.org,
        lgirdwood@gmail.com, linux-media@vger.kernel.org, kernel@puri.sm,
        linux-kernel@vger.kernel.org, Angus Ainslie <angus@akkea.ca>
Subject: Re: [PATCH] media: i2c: dw9714: add optional regulator support
Message-ID: <YZ93/dhTH3pUUHm2@sirena.org.uk>
References: <20211125080922.978583-1-martin.kepplinger@puri.sm>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="4QVRVVhlXziUnvSo"
Content-Disposition: inline
In-Reply-To: <20211125080922.978583-1-martin.kepplinger@puri.sm>
Precedence: bulk


--4QVRVVhlXziUnvSo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Nov 25, 2021 at 09:09:22AM +0100, Martin Kepplinger wrote:

> +	dw9714_dev->vcc = devm_regulator_get_optional(&client->dev, "vcc");
> +	if (IS_ERR(dw9714_dev->vcc)) {
> +		if (PTR_ERR(dw9714_dev->vcc) != -ENODEV)

This looks like an abuse of regulator_get_optiona(), unless the supply
might be physically absent in a system it should be using a normal
regulator_get().

--4QVRVVhlXziUnvSo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGfd/wACgkQJNaLcl1U
h9Cl1gf9GoBR+vf/0EfzsbiofJ5XWkU85yZeb9CHrqdjL2qDftsuuzNtTYUMQNYO
fUVEQ3Gt76NLGDIf/h68BsRi00I8Lkug3VoIZtQSf5CNgO/6yKlzgjjTnsqPsGV7
bTtzlfE6uJr4YPZPwg8cj5cIk+22ixWs21XMMS1Ho/mvn/8ECoDNd/XoXTz7wsTZ
lRGUW6v1XOlvNASOqDX1LNe6p05S7eFc0guqPKgHonnOntOTu1QqRTVDsLWqCmpK
DGzgi/Mcd/D5JYjeWy7zc2tYSJQzmtrx2ZVnzzMfY0QHFyo/zcORDIQ4WUT2An1I
o/XVw0bGVfooWL2wXLC56R9rZ1Go/A==
=eA3p
-----END PGP SIGNATURE-----

--4QVRVVhlXziUnvSo--