Message-ID: <24781209-928b-dea4-de0b-b103dac8de82@axentia.se>
Date:   Thu, 25 Nov 2021 14:35:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH RFC v3 1/4] dt-bindings: mux: Increase the number of
 arguments in mux-controls
Content-Language: sv-SE
To:     Aswath Govindraju <a-govindraju@ti.com>
Cc:     Vignesh Raghavendra <vigneshr@ti.com>, Nishanth Menon <nm@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Marc Kleine-Budde <mkl@pengutronix.de>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-can@vger.kernel.org,
        linux-phy@lists.infradead.org
References: <20211123081222.27979-1-a-govindraju@ti.com>
 <20211123081222.27979-2-a-govindraju@ti.com>
From:   Peter Rosin <peda@axentia.se>
Organization: Axentia Technologies AB
In-Reply-To: <20211123081222.27979-2-a-govindraju@ti.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NzQ3eHZYcUp0YjAyc0JjbGtFZEFNUHZ4YXBjOVozeGVFTUdkVU9UYzNnRExp?=
 =?utf-8?B?b1JYWFNzY1NLVkhxSWxoanBmMDlaQUdPR1dlVXNyS2NHR3RCSFlyRUNPcUt5?=
 =?utf-8?B?SGFnTVNzUGttSFVxNTRGeXVEVWNNUUl4Q0lTSGcyYzEralU4KzR1Rk1Uc0FL?=
 =?utf-8?B?ZFNxanlrak9neExvWmFEa1pQWVd0L2RZNnpnUU9iMW1zWGppWGFBeEN3S0N1?=
 =?utf-8?B?UUQ2U0xEdGdtTWJZT3dtTVZjdWZqQlFwNUVSL241ODZMb3JaZGZScmsrakhG?=
 =?utf-8?B?NTc2RlgxRkhtOEFVeG9lZ04wa2tTK3RrejhZV2xBd1g0UDdJLzdxYnNBYUEv?=
 =?utf-8?B?SHhEZ3pvWWpZQWZoeCtyK09VV0x2Tkx2aXRzdlZBQnpZRFZKYjVsbHVFcFFO?=
 =?utf-8?B?aEUyN1lSWmpaOTk5Q1RPeVhseUM3aXkvR2M0OHFScVYveGpqMlJWQWNodW53?=
 =?utf-8?B?VUJibHZiTU9sYUEvdjBSYldFRGF4eGtLbFpscU91dFpSR2tuTWsyQ1J1ekRM?=
 =?utf-8?B?QmNXSGhxb1F5MUttRlFtaHFTS1RpYVF2Mk4xd3lLR29HV1NIYVh4Y1FCQnpm?=
 =?utf-8?B?Z2dCaW1MUUgzNEtpUFgvT0xHZm0vR2NOSmhyZldUcytpcHFsU0YyeGxacVNP?=
 =?utf-8?B?U053Q0hYcW1UUFlKdzVQQkpQTHpPMyt2QlhVNjVGbWVXTDg0L3lTa3QxaE5p?=
 =?utf-8?B?SzRhTnRNWU9VSlkyRVBoSFZzK0NTL2trRGxOZHNieHVlNDFyN3grNEt4U1Ew?=
 =?utf-8?B?WUJOUXN6TkZqUEZNcW84UTliMXU3S01qU3pLMFJ4TDlkRWwrOXVZeDN5ZWhv?=
 =?utf-8?B?Q3pEaEt4cFFZcG8vREEwYnYrSnFNS050eitheS9FVmptbWxDTHl5UHdRRnFU?=
 =?utf-8?B?MkRZZFFDZTJOb004eWVmR3RlalVaSjhqaVpIUlppTW1TNUVBaUs5QnRJZ0Jn?=
 =?utf-8?B?c243VFJEaDNyS1QwZkhOU1RLb0NnM3haVUZaM2Q3VVlYUmRvbi9ISFNCcUly?=
 =?utf-8?B?NHIvYVA0bjY5ZzJEcGxTRjZGRWRrNUhBdGdZUGRmT2d4MFRmR2pEdCs4UDVW?=
 =?utf-8?B?ODZwRG5oeGx5WFlYYVRlb2RnalEwcE1FUXRpZFNucGEwYkRSdjRuVWF4aXlU?=
 =?utf-8?B?MDZlNzYxS2ppVjJyRi9PSXN2ZGZTUkg3QTRablJuWmlQQlpJcjhCY2tvNkVp?=
 =?utf-8?B?Qzk5aGJpbmNqTVpINktUMS85b3E0aHg4WTFGK0tSc0VVMnZuNm1GeWhtcWR0?=
 =?utf-8?B?M3Q0U05QbGpxMlgvTDkrZldUODdFTlJ4YzYvRFhKRkhVc1U3UVRIeEJwVWJv?=
 =?utf-8?B?eHpYUmNSUnQvWlJLRGVBV2J4cTJpNmVVV0sxeU5LOHFrZU1sWWtEaWQxUFhG?=
 =?utf-8?B?VUwzejFEdzFNZjVpTHBnQWJKTXdRRUlUYzJlSTVvOFdMdWN1aTBPZlQzcVNM?=
 =?utf-8?B?dkNKTWpvQnpPWmIwTWhONGtNcXVOZG1jNE80VjEyUUhOM3hIRjk0K1lzanB4?=
 =?utf-8?B?R1pscXUwdVNtTC8vMTI3RVJ0d3F4R0l6MzNsNW41UjFRZENJdk9JV3E0ZEdw?=
 =?utf-8?B?bVFyZGRiem5IdkNBVWdDN0ljamNDbE1sRW55V1BzQjFQMDlHU3FWbEhiQ1JW?=
 =?utf-8?B?R0tldGlDVXBrWTBvQ2xhZmswYVlvZDM3bk8vSVU0WmtadDgreTRHRVFtRGZz?=
 =?utf-8?B?TkxvM1pIS21HVEJaVys2cFRnZVVmdVNHTEJMdk5NdytLN0ozVmhJL1liKy9X?=
 =?utf-8?B?TnNMT3BHMTZHNUlyZkhsejZOb1FKaGNmbFRYSU1tM1BkQVNzY3M2MzNJS1h1?=
 =?utf-8?B?VGcvbUU1SkpNN3hnTlFycEkxcUhyMDF3Y3lVYmhKWUJzekdpREZKRjA5a29D?=
 =?utf-8?B?M1pGY3hNaS9PUUIrTVdTeTA4UFlPZlozb25jK0tpQ3pRMGYvcTNoV3Y4bW16?=
 =?utf-8?B?aDJ2a2hRM1lKOVFhQ1p6eHJGNGp6Q3Jwa2pCT2cyWHRKQlZJZ09QYlk1WGZw?=
 =?utf-8?B?aG1uMk5wQVM4UklzZ0oyN3g4Z21NaTF0NHZYUkdvZDdQZzVpbWpMbk8wUjdB?=
 =?utf-8?B?Q3dYZzl0eUFLMU9BRGx0TzBnbW9MTXJIZjhYbHplNldGOWVIUHlZT0ZrZ3R0?=
 =?utf-8?Q?AsJc=3D?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: a2d107ef-bd8a-4749-1b27-08d9b01879ba
X-MS-Exchange-CrossTenant-AuthSource: DB8PR02MB5482.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2021 13:35:42.0657
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6iQk5Ohwp0mkpS/Z0W0HJmB4LqRl6rRocFPkFH+nhL1B+fjVM+tGaWWQ9mlnauAp
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0201MB2293
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

You need to have some description on how #mux-control-cells now work.
The previous description is in mux-consumer.yaml and an update there
is needed.

However, I have realized that the adg792a binding uses #mux-control-cells
to indicate if it should expose its three muxes with one mux-control
and operate the muxes in parallel, or if it should be expose three
independent mux-controls. So, the approach in this series to always
have the #mux-control-cells property fixed at <2> when indicating a
state will not work for that binding. And I see no fix for that binding
without adding a new property.

So, I would like a different approach. Since I dislike how mux-controls
-after this series- is not (always) specifying a mux-control like the name
says, but instead optionally a specific state, the new property I would
like to add is #mux-state-cells such that it would always be one more
than #mux-control-cells.

	mux: mux-controller {
		compatible = "gpio-mux";
		#mux-control-cells = <0>;
		#mux-state-cells = <1>;

		mux-gpios = <...>;
	};

	can-phy {
		compatible = "ti,tcan1043";
		...
		mux-states = <&mux 1>;
	};

That solves the naming issue, the unused argument for mux-conrtrollers
that previously had #mux-control-cells = <0>, and the binding for adg792a
need no longer be inconsistent.

Or, how should this be solved? I'm sure there are other options...

Cheers,
Peter

On 2021-11-23 09:12, Aswath Govindraju wrote:
> Increase the allowed number of arguments in mux-controls to add support for
> passing information regarding the state of the mux to be set, for a given
> device.
> 
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
>  Documentation/devicetree/bindings/mux/gpio-mux.yaml       | 2 +-
>  Documentation/devicetree/bindings/mux/mux-controller.yaml | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mux/gpio-mux.yaml b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
> index 0a7c8d64981a..c810b7df39de 100644
> --- a/Documentation/devicetree/bindings/mux/gpio-mux.yaml
> +++ b/Documentation/devicetree/bindings/mux/gpio-mux.yaml
> @@ -26,7 +26,7 @@ properties:
>        List of gpios used to control the multiplexer, least significant bit first.
>  
>    '#mux-control-cells':
> -    const: 0
> +    enum: [ 0, 1, 2 ]
>  
>    idle-state:
>      default: -1
> diff --git a/Documentation/devicetree/bindings/mux/mux-controller.yaml b/Documentation/devicetree/bindings/mux/mux-controller.yaml
> index 736a84c3b6a5..0b4b067a97bf 100644
> --- a/Documentation/devicetree/bindings/mux/mux-controller.yaml
> +++ b/Documentation/devicetree/bindings/mux/mux-controller.yaml
> @@ -73,7 +73,7 @@ properties:
>      pattern: '^mux-controller(@.*|-[0-9a-f]+)?$'
>  
>    '#mux-control-cells':
> -    enum: [ 0, 1 ]
> +    enum: [ 0, 1, 2 ]
>  
>    idle-state:
>      $ref: /schemas/types.yaml#/definitions/int32
>