Message-ID: <68615778-08cc-6216-1def-764dff112a72@redhat.com>
Date:   Thu, 25 Nov 2021 15:47:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH v2] kthread: dynamically allocate memory to store
 kthread's full name
Content-Language: en-US
To:     Petr Mladek <pmladek@suse.com>
Cc:     Yafang Shao <laoar.shao@gmail.com>, akpm@linux-foundation.org,
        netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        oliver.sang@intel.com, lkp@intel.com,
        Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Andrii Nakryiko <andrii.nakryiko@gmail.com>,
        Michal Miroslaw <mirq-linux@rere.qmqm.pl>,
        Peter Zijlstra <peterz@infradead.org>,
        Matthew Wilcox <willy@infradead.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Kees Cook <keescook@chromium.org>
References: <20211120112850.46047-1-laoar.shao@gmail.com>
 <435fab0b-d345-3698-79af-ff858181666a@redhat.com> <YZ+hsx52TyDuHvE1@alley>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <YZ+hsx52TyDuHvE1@alley>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25.11.21 15:46, Petr Mladek wrote:
> On Thu 2021-11-25 10:36:49, David Hildenbrand wrote:
>> On 20.11.21 12:28, Yafang Shao wrote:
>>> When I was implementing a new per-cpu kthread cfs_migration, I found the
>>> comm of it "cfs_migration/%u" is truncated due to the limitation of
>>> TASK_COMM_LEN. For example, the comm of the percpu thread on CPU10~19 are
>>> all with the same name "cfs_migration/1", which will confuse the user. This
>>> issue is not critical, because we can get the corresponding CPU from the
>>> task's Cpus_allowed. But for kthreads correspoinding to other hardware
>>> devices, it is not easy to get the detailed device info from task comm,
>>> for example,
>>>
>>>     jbd2/nvme0n1p2-
>>>     xfs-reclaim/sdf
>>>
>>> Currently there are so many truncated kthreads:
>>>
>>>     rcu_tasks_kthre
>>>     rcu_tasks_rude_
>>>     rcu_tasks_trace
>>>     poll_mpt3sas0_s
>>>     ext4-rsv-conver
>>>     xfs-reclaim/sd{a, b, c, ...}
>>>     xfs-blockgc/sd{a, b, c, ...}
>>>     xfs-inodegc/sd{a, b, c, ...}
>>>     audit_send_repl
>>>     ecryptfs-kthrea
>>>     vfio-irqfd-clea
>>>     jbd2/nvme0n1p2-
>>>     ...
>>>
>>> We can shorten these names to work around this problem, but it may be
>>> not applied to all of the truncated kthreads. Take 'jbd2/nvme0n1p2-' for
>>> example, it is a nice name, and it is not a good idea to shorten it.
>>>
>>> One possible way to fix this issue is extending the task comm size, but
>>> as task->comm is used in lots of places, that may cause some potential
>>> buffer overflows. Another more conservative approach is introducing a new
>>> pointer to store kthread's full name if it is truncated, which won't
>>> introduce too much overhead as it is in the non-critical path. Finally we
>>> make a dicision to use the second approach. See also the discussions in
>>> this thread:
>>> https://lore.kernel.org/lkml/20211101060419.4682-1-laoar.shao@gmail.com/
>>>
>>> After this change, the full name of these truncated kthreads will be
>>> displayed via /proc/[pid]/comm:
>>>
>>>     rcu_tasks_kthread
>>>     rcu_tasks_rude_kthread
>>>     rcu_tasks_trace_kthread
>>>     poll_mpt3sas0_statu
>>>     ext4-rsv-conversion
>>>     xfs-reclaim/sdf1
>>>     xfs-blockgc/sdf1
>>>     xfs-inodegc/sdf1
>>>     audit_send_reply
>>>     ecryptfs-kthread
>>>     vfio-irqfd-cleanup
>>>     jbd2/nvme0n1p2-8
>>
>> I do wonder if that could break some user space that assumes these names
>> have maximum length ..
> 
> There is high chance that we will be on the safe side. Workqueue
> kthreads already provided longer names. They are even dynamic
> because the currently handled workqueue name is part of the name,
> see wq_worker_comm().

Great, thanks!


-- 
Thanks,

David / dhildenb