Message-ID: <54e872a6-7531-68ba-4cee-f333be2305fa@oracle.com>
Date:   Thu, 25 Nov 2021 10:20:51 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.1
Subject: Re: [PATCH v4] xen: detect uninitialized xenbus in xenbus_init
Content-Language: en-US
To:     Stefano Stabellini <sstabellini@kernel.org>, jgross@suse.com
Cc:     xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
        jbeulich@suse.com,
        Stefano Stabellini <stefano.stabellini@xilinx.com>,
        stable@vger.kernel.org
References: <20211123210748.1910236-1-sstabellini@kernel.org>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211123210748.1910236-1-sstabellini@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEQ5RzR2bHRUSHdtWG8yQisxRTFwUFpnejZBT2xpa2VtNkdnWnBEaUFTR0ho?=
 =?utf-8?B?WkxmV0ZpZHpMWjRTS3A0aE1td1JPV0FucFFiNE5PODIxOFl2bC9XU21hK1Z0?=
 =?utf-8?B?RFFKT2NRM2dxM1FNRURJSlhuWkxid0NHbElROVVUOHJXcnEzeVRqUzRwTUVJ?=
 =?utf-8?B?OHJXQ01WT1JNeG1NVXkxYzE4U0lCQ2ljV3BoaFY4TlJhd1kzSzhVZit1UUI5?=
 =?utf-8?B?UFg4bnZhSGRrdUIvaDJiVUFieDNoMm1iblNnMlVoQkh5NFFPYUNwK3ZZN2hX?=
 =?utf-8?B?QTM3cUpJdHR4N2lqc2pEYVFkOEw0NGhXbWVwVzRBNUpSMEhneXE0aVAraUt5?=
 =?utf-8?B?TWpMcGpodUdrWDdOMHo2Tk1xZmx4ZmpQN3lzclNYazM1VzJzRlRiNVU1SzdS?=
 =?utf-8?B?YzlVbWduZVZEMms0a2lnNCtsbWM4N3JhODRtc1Z6bDMwd2ora3E1RTl2ZmhP?=
 =?utf-8?B?VjJoTCthMFpCZzNkOUVCRUpyN2t4aUdQemtrMmVPNUM1SmQzOHR0dStIYkQ5?=
 =?utf-8?B?U1VoQXcwbCtYKy8wOE53d2dYUUZnVEhvL3F5VEJXa1NMbUJhczZISEFqSll6?=
 =?utf-8?B?Nm1xTGczTWpabFROMlJ2MldjRU83dTZVUllhQWVFRnlBd3BGRDJaa2hqa09N?=
 =?utf-8?B?QVVUbFRDd0FsNERPMWx2aGlPNkJWR2sxb2laeHY0dCtqc1RoWEVpUVpCSk40?=
 =?utf-8?B?KzNDSFFqcXRrS3lESVcyeE9IL3BTWEhGd3NFbVM5M25LRFdUM3NVenlQbjF0?=
 =?utf-8?B?bzhGQXpGVTFza0VIWmorWGJzdWkrS1ZEVzl5QjUyMHl5bnd2MStaeFJmMFdj?=
 =?utf-8?B?d1h3SGZ3MDdhdi9aUzc1MlVWZW1CeWtIbWU0bXNiaDROeDJjd21YZGxTbVpz?=
 =?utf-8?B?VTI0VW4zelhQc1MyQXU2RzBoVFp3aE83OC9mYWluK1RRM201NXZJclpwVFZj?=
 =?utf-8?B?clJUUlI1ZzhVUjdNWUtKVThkSHhRREdZbk9YUHVsN0FuT0RrMjJGN3lRNlRR?=
 =?utf-8?B?R0V3MGZKMkdyOHpLSEFJckFYOEdVaFQ4d0djUy9SRC9XMEhzRUp4SGE0Qmh4?=
 =?utf-8?B?SmV3T09LanYrQVkwYXdPcHpoNER2RGlYZExiZFlHTkUxeVpRaHNUcTF1eTZC?=
 =?utf-8?B?Y3VnUVBkS3BaMytyTDJOMmNFbzBmbWRsL0FYZHJVZmtDV2VSN2QrUGh5Y01a?=
 =?utf-8?B?Y29vV1Zza2lTOHB6SVBuVFZuUWNZclMzRkxVSTlORlFBNzE2YmROUHJIaUs5?=
 =?utf-8?B?SkxIOHUySmlPK2xEOGs5MVEzVjMvTERRNUhjNnVDaDFaZUZUVXFGVm1zQjR2?=
 =?utf-8?B?VERMQS94dEUzL2JUY2dUVStzcHEyQUcyM1k4YUZ0d2hPTlJ2RHVSdjRmalNw?=
 =?utf-8?B?T1RTeVo3cGZQY2J5bVIrSDBTcFJSVjhta1I2VlBjNVAvU1liRXM1ZHBtVnpo?=
 =?utf-8?B?aThUNHMrMW9Cb283dTFyTmI4MmtEOGl0Slh6RFZ1TWtVVVdpcktOWWIyeTFO?=
 =?utf-8?B?VmpJSVVCVlIzZnc1alJuRGlUbWRVaUlTU0JBV3NWNGZJR2Q2VGpuV1VCVE02?=
 =?utf-8?B?U3RaWFAxdDhrWCt0RG40ekkyM0c2NWdJaGJwd0JydjJnaUhCUVM3bDZCREsr?=
 =?utf-8?B?VTJXNFAzeWF2UTlrLzFzb21ZVW5yVGo4aEFweHZwV2dvOEVPdklSZkVHYkMr?=
 =?utf-8?B?ZmtOQ1ljS2Y2QjZUNWEwMmlMcVQ0UmFLYzkwVXJVVWQ2V21jQzZCVC9jazI5?=
 =?utf-8?B?NHVRM2h2WXdUZlJoSC91RmtsbC9vSVBXZ000d0pySkJRcmVhNUZKV3RubkRS?=
 =?utf-8?B?aUtyOHZLaXc3ZE4ycndxbTRSSUZSMWZlZTRSazAyWmVuL1o5RlAwSUkyR1ZM?=
 =?utf-8?B?YTNBQ2lybU9tY3d0bDlOME1nZGlxZDhaVmlYTmNyblh4dlRISlhqVFZFN282?=
 =?utf-8?B?RjFNY05EdTdieDA4ZFNQQnJSdDh0ampBbkFUU3I2ZDhaejgrNFo4NnJGYUNt?=
 =?utf-8?B?VFJPNEdXTHFFNWZpbStWQk5WeDdncTg5Sk90Y3RhU0llSzdrZWVuQ2VOclZP?=
 =?utf-8?B?cEdncWNhNThiYVhoeXlhVmUxWUQwOHA0VHRuNFRvcHhJUlNKT1dpVDlER2JV?=
 =?utf-8?B?SU41UkFYL2R3WTR3ZnRrRDZiWHc2TWZkcGpkWm5MeWdyYndKUGtBLzlyQndj?=
 =?utf-8?B?ZG5NNzhHcjErd28yOFpnNFpnWnpleVBQNG5WOWlueDZhSDJRQkxwR3ZjRlYr?=
 =?utf-8?B?WTVBbjJROUtxMUlYYy8yUVEzQmJnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09169b10-c57b-4ba9-6fc1-08d9b0272e9d
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2021 15:20:58.3720
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xo4gk7qnMMctrtpFHmXFpgGTx5zbK5jL75yAl+2wkuTRq7s55ZBTD65ui1q6ms94bkDcuU6zn4zZIweyMqbGNfMRFL3YzP8r2cDdoMTCHuk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4383
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10179 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 mlxscore=0
 bulkscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111250085
X-Proofpoint-ORIG-GUID: pnDtrLdeU98Io3rOv_HuJp9gfcEpXX5x
X-Proofpoint-GUID: pnDtrLdeU98Io3rOv_HuJp9gfcEpXX5x
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/23/21 4:07 PM, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
>
> If the xenstore page hasn't been allocated properly, reading the value
> of the related hvm_param (HVM_PARAM_STORE_PFN) won't actually return
> error. Instead, it will succeed and return zero. Instead of attempting
> to xen_remap a bad guest physical address, detect this condition and
> return early.
>
> Note that although a guest physical address of zero for
> HVM_PARAM_STORE_PFN is theoretically possible, it is not a good choice
> and zero has never been validly used in that capacity.
>
> Also recognize all bits set as an invalid value.
>
> For 32-bit Linux, any pfn above ULONG_MAX would get truncated. Pfns
> above ULONG_MAX should never be passed by the Xen tools to HVM guests
> anyway, so check for this condition and return early.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>


Applied to for-linus-5.16c


-boris