Date:   Thu, 25 Nov 2021 15:24:15 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Satya Priya <quic_c_skakit@quicinc.com>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>, swboyd@chromium.org,
        collinsd@codeaurora.org, subbaram@codeaurora.org,
        Das Srinagesh <gurus@codeaurora.org>,
        linux-arm-msm@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 2/6] dt-bindings: regulator: Add pm8008 regulator
 bindings
Message-ID: <YZ+qn2hA4MzNEqM+@sirena.org.uk>
References: <1637314953-4215-1-git-send-email-quic_c_skakit@quicinc.com>
 <1637314953-4215-3-git-send-email-quic_c_skakit@quicinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="CswzH+vgELyYIlv6"
Content-Disposition: inline
In-Reply-To: <1637314953-4215-3-git-send-email-quic_c_skakit@quicinc.com>
Precedence: bulk


--CswzH+vgELyYIlv6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Nov 19, 2021 at 03:12:29PM +0530, Satya Priya wrote:

> +properties:
> +  compatible:
> +    const: qcom,pm8008-regulators

Why are we adding a separate compatible for this when we already know
that this is a pm8008 based on the parent?

> +  vdd_l1_l2-supply:
> +    description: Input supply phandle of ldo1 and ldo2 regulators.

These supply nodes should be chip level, they're going into the chip and
in general the expectation is that you should be able to describe the
supplies going into a device without worrying about how or if any
particular OS splits things up.

--CswzH+vgELyYIlv6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGfqp4ACgkQJNaLcl1U
h9Dr+Af9FLcGk6WdCH+gR9n1V50xl6lQHFr24c6T9C95z/NK0w7JfDffo6TSTDGL
GmiESrCqPxdpXeWjB9irMYdZQ654ZWXriQ0cf94mQt3cuOs92HMcMP+6MMdHJL00
woFVqYyMWzAhXoDB7R+iI2pbI4DwgBU7ZHNQLRZ5MnXMJ5Yb/kqG2ZKTxNbzpylb
XgP6SddLv9y+cesJODllwyiLbIf0Mbt54eD+e57pmkMy1HDxOKMJdtWPpF9m2U7i
hLE8dm2G9nUzmKJVhSjix3rkA8h++OZBzzoUly3dbry+yTV7Ej+Asr629driMH6W
AW+qU/Y9zDYqjHSEe5JYPGRhooOldQ==
=gTjl
-----END PGP SIGNATURE-----

--CswzH+vgELyYIlv6--