From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>
CC:     Niklas Cassel <Niklas.Cassel@wdc.com>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] nvme: report write pointer for a full zone as zone start +
 zone len
Thread-Topic: [PATCH] nvme: report write pointer for a full zone as zone start
 + zone len
Thread-Index: AQHX4hdRt5zKIuN2cE+GwwUsJOKF0w==
Date:   Thu, 25 Nov 2021 16:13:01 +0000
Message-ID: <20211125161247.164381-1-Niklas.Cassel@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?xY9H1YSX5FjGGAt77hzVb8WQSXsKtT5u/zPOBcNEEH5iLimNqc94Dr9jJB?=
 =?iso-8859-1?Q?dFrVAvV0e0ZF4j3SlBvGriheC/stVMvowtwb/isAwikacT8LwaLvDVv/XV?=
 =?iso-8859-1?Q?RRrF6b0IjE4XpMMvOL1MdiW+Bcviqr++r4cMTB9f211JSd5z/RzyVDCIyb?=
 =?iso-8859-1?Q?wWpjgNc+CoRZy+/6fMk4d2nA9yTQmuZ/U21gL8DnBXDf/6Sv9A5f+mjhWa?=
 =?iso-8859-1?Q?JVfZY89GwUoKO1vqf23c0qFmcK6d6iZTSG0Jol6rYAMmUdw3MUNe8bKjgg?=
 =?iso-8859-1?Q?HMofz19Hn7s33udgA72ANS6M5YOyfdoAMQbNI3/dgEPYa9/Fi5vt6v766e?=
 =?iso-8859-1?Q?HheWwiGfOIfHhIDvBMhRp1L5GKZJhAzhin1rYvY/izUcqgyuhJ+TM2mu1/?=
 =?iso-8859-1?Q?HunbCb5UrEEihtyvWUCf27l0lCUKD+whTZfcVFuerf0dI4ezOuX8vzjXjy?=
 =?iso-8859-1?Q?4BZBZrp6Y5do6gIZk0Y2Lhb+Ntjogcou6TkkGvvVY0WrhfEh7BuPURPOg9?=
 =?iso-8859-1?Q?/ZN23GaaPJSFlnfn/tPVj8eHae+OXkK0NK4L27JQ1I9rARLdWRK/0NLygp?=
 =?iso-8859-1?Q?pjR7p4IByRPrxTwpKuR9dELzBoxXx57DBHakRJFLJDB3vUUmkwNJEJAp8E?=
 =?iso-8859-1?Q?aKqxU5elR66DAzryoPSmFuzOklLlsbRsj2I/sZ5Gra2mcUdZkPzBAvHMc6?=
 =?iso-8859-1?Q?ByCY4oX61xa7O7uPJDWSkD9E//GgM8/ZNlynvg0K/RxUL8/Nf4+ycG/+X0?=
 =?iso-8859-1?Q?UkIKnO31ulaUNFNIDCOtEh+su2ZU0CpGB0Z0IE9q/RSlS3fAT2hq8TYlId?=
 =?iso-8859-1?Q?NvREDO0F40IEFnHZbYpdhcdNuxu80UZ86RlqpwlMVOqvAA1n4+VxTiUPlB?=
 =?iso-8859-1?Q?ggoI8KLcyytFA8JsbuijWODHVtjinGDt7UHunXRqv2A6ac6FiTN1w2FO0y?=
 =?iso-8859-1?Q?MDbbdaHV7oxCOAT5Ang4S3RktRR4hf48UJ16vi40SZiyyvnpLDG5TeNdwI?=
 =?iso-8859-1?Q?uZZDOyqumdmNb/AQvDS3o/LncgPSDYDuWkV2UB40Sz+isgA0Vx8Xs4DM2Z?=
 =?iso-8859-1?Q?9eiy96l2J1h6B2tX3qByP6YjOu10+UPMT8cWgoVGDpO0hp22sYRE5uEVVW?=
 =?iso-8859-1?Q?RXuPmExIb8oelilvl0LeK6ylGUzgojI+P3271WXQli2VkQuss7BZL7n0as?=
 =?iso-8859-1?Q?KViGxWaRF2UJL/qtd/bbw6XVRmqTDbCfTf5oVQT4nl3ULmGPKcuhiZ+Nbj?=
 =?iso-8859-1?Q?Ly7pmrql03a6t+DtYeM6CrGa9BCp13buv+fnHI93RK9tIlYAiuOHKUtNAq?=
 =?iso-8859-1?Q?as3glkhFEaYT7ZBuT+Kmtu9ydMmZduUPTkCvc/3y8jLjCsf92oEaqPMWDG?=
 =?iso-8859-1?Q?XWv2mHyCrcbT80ez/XXQYDCkloNAwZNt8rPde45VOi4j2CSTT7YXTBsYjg?=
 =?iso-8859-1?Q?mEXg0ndoM3wiDSaVGGXuHVHur+e+eKaxlgqQd7/bNX8vgy7bS/wioWBaY+?=
 =?iso-8859-1?Q?gyRmwRLB+VhemnjJ7/0blFl6hGFacUSc+vIvdMdLTx1mIsZYtrhGohrJZ1?=
 =?iso-8859-1?Q?/KoM8YE3j+LjnElErw/Iilgnxt1RHB+tr2XWVNJ8Dq9JZf/vXNsXdjtzzS?=
 =?iso-8859-1?Q?I4rOd9lYAUtf3/pFEFIT6NOtRixOt3UPvO+0zRE9wSmgwIvqOSWTs2gsgB?=
 =?iso-8859-1?Q?62zI7DAgL3m6TwmZOkE=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7158.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a19c671-f100-4bf2-f5e6-08d9b02e7438
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2021 16:13:01.2857
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dzLAcC9bTkEegZp7BchnJ/63FsxeJM8MQSylwTDE2fmP9RE7ir4rC4PU3fZm5hAOSY81RpeeijL3G5+/1FmZxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7269
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Niklas Cassel <niklas.cassel@wdc.com>

The write pointer in NVMe ZNS is invalid for a zone in zone state full.
The same also holds true for ZAC/ZBC.

The current behavior for NVMe is to simply propagate the wp reported by
the drive, even for full zones. Since the wp is invalid for a full zone,
the wp reported by the drive might be implemented as a don't care term.

The way that the sd_zbc driver handles a full zone is to always report
the wp as zone start + zone len, regardless of what the drive reported.
null_blk also follows this convention.

Do the same for NVMe, so that a BLKREPORTZONE ioctl reports the write
pointer for a full zone in a consistent way, regardless of the interface
of the underlying zoned block device.

blkzone report before patch:
start: 0x000040000, len 0x040000, cap 0x03e000, wptr 0xfffffffffffbfff8
reset:0 non-seq:0, zcond:14(fu) [type: 2(SEQ_WRITE_REQUIRED)]

blkzone report after patch:
start: 0x000040000, len 0x040000, cap 0x03e000, wptr 0x040000 reset:0
non-seq:0, zcond:14(fu) [type: 2(SEQ_WRITE_REQUIRED)]

Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
---
 drivers/nvme/host/zns.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/zns.c b/drivers/nvme/host/zns.c
index bfc259e0d7b8..4091b955ce62 100644
--- a/drivers/nvme/host/zns.c
+++ b/drivers/nvme/host/zns.c
@@ -167,6 +167,8 @@ static int nvme_zone_parse_entry(struct nvme_ns *ns,
 	zone.capacity =3D nvme_lba_to_sect(ns, le64_to_cpu(entry->zcap));
 	zone.start =3D nvme_lba_to_sect(ns, le64_to_cpu(entry->zslba));
 	zone.wp =3D nvme_lba_to_sect(ns, le64_to_cpu(entry->wp));
+	if (zone.cond =3D=3D BLK_ZONE_COND_FULL)
+		zone.wp =3D zone.start + zone.len;
=20
 	return cb(&zone, idx, data);
 }
--=20
2.33.1