Date:   Thu, 25 Nov 2021 17:17:53 +0000
From:   Catalin Marinas <catalin.marinas@arm.com>
To:     Calvin Zhang <calvinzhang.cool@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Subject: Re: [PATCH] mm: kmemleak: alloc gray object for reserved region with
 direct map.
Message-ID: <YZ/FQXS3gWZ2xfEy@arm.com>
References: <20211123090641.3654006-1-calvinzhang.cool@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211123090641.3654006-1-calvinzhang.cool@gmail.com>
Precedence: bulk

On Tue, Nov 23, 2021 at 05:06:41PM +0800, Calvin Zhang wrote:
> Reserved regions with direct mapping may contain references to other
> regions. CMA region with fixed location is reserved without creating
> kmemleak_object for it.
> 
> So add them as gray kmemleak objects.

Do you get any kmemleak false positives without this patch? It would be
good to include them in the commit message.

Without seeing a false positive caused by this, I'm not convinced it is
the right approach. You mentioned CMA but telling kmemleak about the
whole CMA region is a pretty big hammer. I'd rather add individual
kmemleak_alloc_*() calls in cma_alloc().

-- 
Catalin