MIME-Version: 1.0
References: <25b36a5c-5bbd-5423-0c67-05cd6c1432a7@redhat.com>
 <CALvZod5L1C1DV_DVs9O3xZm6CJnriunAoj89YLDdCp7ef5yBxA@mail.gmail.com>
 <1b30d06d-f9c0-1737-13e6-2d1a7d7b8507@redhat.com> <CALvZod5sFQbf3t_ZDW6ob+BqVtezn-c7i1UyOeev6Lwch96=7g@mail.gmail.com>
 <92fe0c31-b083-28c4-d306-da8a3cd891a3@redhat.com> <CALvZod4C1V6Gk96oMCMguaqChjggH0KH3KKcU1QOmjRG+QEAbQ@mail.gmail.com>
 <c61a6f30-ed62-7773-3371-981102f6804f@redhat.com> <CALvZod7xTfg5aeQC7-EaOZJ47Twb8CkoS6u4C=8+y+AX-NREVw@mail.gmail.com>
 <1b400921-8bef-8073-10f9-a7cbb09cfefe@redhat.com> <CALvZod6wyF7v1v888StoXSSWtb7ujaeBUnUB8Vs2RfMzUsj+Gw@mail.gmail.com>
 <YZ9gz8WGic8QOTxE@xz-m1.local>
In-Reply-To: <YZ9gz8WGic8QOTxE@xz-m1.local>
From:   Shakeel Butt <shakeelb@google.com>
Date:   Thu, 25 Nov 2021 09:14:30 -0800
Message-ID: <CALvZod5166ReiM7J6kbky6+nRxiY5KbAdx4Yh8njnPddR+nXdQ@mail.gmail.com>
Subject: Re: [PATCH] mm: split thp synchronously on MADV_DONTNEED
To:     Peter Xu <peterx@redhat.com>
Cc:     David Hildenbrand <david@redhat.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Yang Shi <shy828301@gmail.com>, Zi Yan <ziy@nvidia.com>,
        Matthew Wilcox <willy@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Nov 25, 2021 at 2:09 AM Peter Xu <peterx@redhat.com> wrote:
>
[...]
>
> Hi, Shakeel,
>
> I saw your v2 has started to pass in zap_details, then we need know the side
> effect on that skip-swap-entry thing because with your v2 code munmap() will
> start to skip swap entry too (while it was not before).
>
> I saw that you didn't mention this in v2 patch either in commit message or
> code, not sure whether you digged that up.  I think it needs some double check
> (or feel free to start this digging by reviewing my small patch above :).
>

I remember mentioning in the patch that this has dependency on your
rfc patch. Just checked again and yeah I only mentioned in the
'changes since v1' section. I will add it more explicitly in the
following versions.

I will take a close look at your patch as well.