Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751137AbXAOSc3 (ORCPT ); Mon, 15 Jan 2007 13:32:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751147AbXAOSc3 (ORCPT ); Mon, 15 Jan 2007 13:32:29 -0500 Received: from styx.suse.cz ([82.119.242.94]:48998 "EHLO mail.suse.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751137AbXAOSc2 (ORCPT ); Mon, 15 Jan 2007 13:32:28 -0500 Date: Mon, 15 Jan 2007 19:32:07 +0100 From: Vojtech Pavlik To: Jiri Kosina Cc: Simon Budig , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator) Message-ID: <20070115183207.GA6792@suse.cz> References: <20070114231135.GA29966@budig.de> <20070115162541.GA3751@budig.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bounce-Cookie: It's a lemon tree, dear Watson! User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1342 Lines: 32 On Mon, Jan 15, 2007 at 05:44:26PM +0100, Jiri Kosina wrote: > On Mon, 15 Jan 2007, Simon Budig wrote: > > > > thanks for the patch. It seems that it is based on pre-2.6.20-rc1 kernel > > > (this is where the USBHID split happened and generic HID layer was > > > introduced). Could you please rebase it against newer version of kernel > > > and resend it? > > I've updated the patch, will submit it to the list in a few minutes. > > I got it, thanks. > > > > All your changes happen to be in the transport-independent code, so it > > > seems that this would be rather trivial task - probably only pathnames > > > (and diff offsets) will change - your changes should now go to > > > drivers/hid/hid-*, not drivers/usb/input/hid-*. > > Yeah, it was easy to port over. Did the hid-debug stuff disappear > > completely? What would I use instead? > > No, it didn't disappear, it was just moved to include/linux/hid-debug.h. Do you think that makes sense? It's code, not a header file. > Should I wait for an updated patch that uses hid-debug.h again? -- Vojtech Pavlik Director SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/