Date:   Thu, 25 Nov 2021 13:37:16 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     =?utf-8?B?SMOla29u?= Bugge <haakon.bugge@oracle.com>
Cc:     Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-rc v2] RDMA/cma: Remove open coding of overflow
 checking for private_data_len
Message-ID: <20211125173716.GA504001@nvidia.com>
References: <1637661978-18770-1-git-send-email-haakon.bugge@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1637661978-18770-1-git-send-email-haakon.bugge@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGxLUTNhejdlVnN6R3ljN3ZIaVpJbDlDQVprcjFaS2laK3NWUlNaTGU4OEZs?=
 =?utf-8?B?UmZoNFV2ZHU5TlkraStZSm1PeDVySnlxSjRURFJDeWxlM3lkNUZWVkVicFAr?=
 =?utf-8?B?RXJ1Z2RhaGZKdDRURGJKKzVMRFZOWExvUHRFWlVIVy95RUNtQ2I2RVZ4bkFU?=
 =?utf-8?B?Nnlub3BUTXZwcjhxakF6MmZDeXN1NGZ0Y0pTdW5CaWZwejJmRGVMcm1RZHI1?=
 =?utf-8?B?V25oU2k3eDlPdkRPYXk0dHRvNFRhSFZ1RzlDcVBud1BFL2swYjdoMk9hSVB3?=
 =?utf-8?B?T3dqb003UGxqcEQwaFcrQjRmT1czVWRwczllUmtNYVJwMVZpdWplWUIyZVI5?=
 =?utf-8?B?NlRNS0xjbm1qK1FZdWhaVDdadi91T2ZCaVY4T1pKZ1FjWVhMMmE5clpsTGsy?=
 =?utf-8?B?T3ZackJQcnowSU1pcEJlM0l3aHRwMkVIeGpCQkRmZmxxemtGNWN0RkhjODdP?=
 =?utf-8?B?bTErRDRnUk1JQzhZaStabGRjdE56TmphUEx5QzFwYld3dnlFZ1h0ajR2SGdP?=
 =?utf-8?B?SStxOXYzZW9LZWZnZ2VlYkI2TkVtMmtGM2JRUWpabUh2NnprbHQ4WnlKdEV1?=
 =?utf-8?B?WnUwaHB6cFlvK1RDVVd0UFVHRTN3Z1hqbkh1RGZrUlE1OG1BcVJHSEdYSXR3?=
 =?utf-8?B?YXNHWlh1SGZlWVVjWnFDdURkczdYMEcwOE1zWmpNRVIxdC9uZ254YzhaazR5?=
 =?utf-8?B?RmN0Nmp1U0lZWHQ3WnVoQ1hULzFuVWZwY1ZraWY4YjFqeW5Kc2k2d2dISlVN?=
 =?utf-8?B?R090OUJ6dENLejVRNVRZc0c3UmdRY0hMRWNKWDQwb3hrZko2OHpya1BPWTRK?=
 =?utf-8?B?bFhYRkRieHNBR3NhQ1dpZE1SNGhvZkM0cDBpVnc3YVROeE9SdkFxcWZFeG1n?=
 =?utf-8?B?ZithUFpaKzE5eVdFZ0p2WXJQQjJuYjVubGhKSEUxdlpFRGY4aW9xalR0eTZl?=
 =?utf-8?B?SUFnWUljMG9Tc0FtSEdPSDVsME91MzJHUndNSkpkV3h1ZENUWEJGaTNkUWUr?=
 =?utf-8?B?VEx3SkVKUXpIcnF1TkRjdENqZ2VoUnM5TW9qZ1ZDSDhKeUpXMHo1b2hrdG9r?=
 =?utf-8?B?MVlQTk1PWHNxWjlxT2loQ3FWWW9GejNiWTJQcVIrTU56cmVpQWFXK2JYUVFu?=
 =?utf-8?B?OVRzVjl6eXFkcXlxMjhQSzdvUDJHL2I4TUhzWW9iMzg4UEdweDZONFh4SEk4?=
 =?utf-8?B?eDRuM1F4ZkdENDJ6QlE5Zjh6YkdQS0FPK0lOb3dCV0orYjJ3Y3JQUy9OTlVp?=
 =?utf-8?B?bnp6c2t6V1FvVzViamRrdE9HL0ZKQjNMSUF2YitjUU5WOWtiRDRlaXpQK205?=
 =?utf-8?B?aDQxYjIydFp3Ri9ta0RJa0RPOG5HTmU2NUVmQ0REeVFvS3VuNjVRSHBMbFBC?=
 =?utf-8?B?Y2tXUmc2ck9HV01HQUNnbVJHL1gwS0VSeU8vY09RbXNDdzlNVkpKVjErWnNF?=
 =?utf-8?B?RFpYS1VadVpUNFJxZlhZZmRrQjdDZDlraitkRGd5QjAxRTVkV2VlU09ob1Nz?=
 =?utf-8?B?MW5FWkJXTGZ6UnlPRWNjeWY2QUIwMjBUYWpySlZjbW1JS01KVXJRRnJNSGZr?=
 =?utf-8?B?NXVnRzZSVEErWWFGcDlaWWRpYmlPdmMydUtoNUx4WktKL1NPakg0SW9kWmYw?=
 =?utf-8?B?Tk5SM1NFeWRKc2NPUm9yTlpHaEc5ekZWVFBZZ1dFREVucjNnUDlQVGFvWStK?=
 =?utf-8?B?UXBlTHZ4a0R0SkpVYlZiaEYyVGtpeDF4SXp5Q1BHdmN4RFZaQ1djNzFacUQw?=
 =?utf-8?B?aHRYWDB4Q0tKK3ErYUhja0R4VHFwMFlZN1I1Z1dZZ0xuK3N4anBjL1YvS0ZM?=
 =?utf-8?B?R3ptUVRDSlJ1eVhEK0JkVUN4Z095WkczWnVJTkQwSTRQcFZydkpYN2g0Q3RK?=
 =?utf-8?B?THR5clZ5RUhJM0x0K3ZocHVSbmY1SFlxVUJVUzJTWXhLSEtjYTlYbUpHejZs?=
 =?utf-8?B?dWM0ZGJCYUpzUWZuNWNiRW1peW9ybkxQRXd3cGNGU1l1aW9ZZ2U0VVkrc2p0?=
 =?utf-8?B?ZUJzQmhKMlJJYVpUYURldUhjN1UzUytDT0IzZ2dBc25TZThRN0tDVmVjSStG?=
 =?utf-8?B?bm1PcTJNSVRjdlhjV3FKeXNDNVI5KzlJUjlmemt4dldEb1dxYjhiOWp4TWly?=
 =?utf-8?Q?Fo9Q=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4662f928-37cf-4ade-3fc7-08d9b03a3996
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2021 17:37:17.1779
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1x0YF9Q/ApJnmhmR9sWc/hUIVtEd0fBPwp5cOPF5L/O7ow8gor00Z9FsSjY3KxPl
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5349
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 23, 2021 at 11:06:18AM +0100, Håkon Bugge wrote:
> The existing tests are a little hard to comprehend. Use
> check_add_overflow() instead.
> 
> Fixes: 04ded1672402 ("RDMA/cma: Verify private data length")
> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> 
> v1 -> v2:
> 
>    * Also fixed same issue in cma_resolve_ib_udp() as pointed out
>      by Leon
> ---
>  drivers/infiniband/core/cma.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Applied to for-next, thanks

Jason