From:   Parav Pandit <parav@nvidia.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>,
        Dan Carpenter <dan.carpenter@oracle.com>
CC:     "kbuild@lists.01.org" <kbuild@lists.01.org>,
        "lkp@intel.com" <lkp@intel.com>,
        "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Eli Cohen <elic@nvidia.com>, Jason Wang <jasowang@redhat.com>,
        Eric Dumazet <edumazet@google.com>
Subject: RE: drivers/vdpa/vdpa.c:296 vdpa_mgmtdev_fill() warn: should '(((1)))
 << (mdev->id_table[i]->device)' be a 64 bit type?
Thread-Topic: drivers/vdpa/vdpa.c:296 vdpa_mgmtdev_fill() warn: should
 '(((1))) << (mdev->id_table[i]->device)' be a 64 bit type?
Thread-Index: AQHX4cqcCgOc0Z4NNkeu+HNF/OFQ86wUa8WAgAAWjlA=
Date:   Thu, 25 Nov 2021 17:39:42 +0000
Message-ID: <PH0PR12MB5481637D2D18E567C2AC21EFDC629@PH0PR12MB5481.namprd12.prod.outlook.com>
References: <202111250317.VUsGtdox-lkp@intel.com>
 <20211125111511-mutt-send-email-mst@kernel.org>
In-Reply-To: <20211125111511-mutt-send-email-mst@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gmrrf3VCHrpKZ/fp/0SpNqVfK8H/RyOZZ03L/7XdvDgOQGRKkFyaH/gAQtAO?=
 =?us-ascii?Q?uAPFRkcO4BaI144SJ5HTW8fCmVrJaA5qpiWNmfLKetaM2lkNdGrfq1N9MfJ1?=
 =?us-ascii?Q?mirlnkm/Q/uWlMVDUcF8JU0+MvHeUaKaMRnbVX+DnVS1/cC01rRV89FAW9yt?=
 =?us-ascii?Q?QVNBCzPbd2xfyi108NbzrHl1yorSZa1YCuKOq2zwQkyVlIFhbQYiJVnLzbyF?=
 =?us-ascii?Q?VAx6iIj46uvcw/0gIMoC5yoE6vR9KHqRm8uUkeLIAOYa0S8YTsA82tRDwKUt?=
 =?us-ascii?Q?UQ8v1YX+86bGniMEQvr3hA9Po5W560YK/YrclQYLkBwxY3HWblv0unO9Rciq?=
 =?us-ascii?Q?KqZQLubGOUyJ8mvRNe84NWFbvM7QHL9W/cguixPu/bO9avyh4+ank7Z7Y6P/?=
 =?us-ascii?Q?v0nMJORTl+JnNDyfn14F095DtOy5n+n3ELeQti1EU/axcU2QTQJeBtLyHQ5g?=
 =?us-ascii?Q?Fh7vJu11MNNSqg3Gu9M8PkkkOsEI2+mjyGA5L9t3b65e2yY42XX6R/nJs6b+?=
 =?us-ascii?Q?lGXeN6Z+9dZnhja6QWRPK3E5fapvA3jnjXsqvgTl9C21rKRft4Rj3BJ1OpIa?=
 =?us-ascii?Q?GR9UqAKNfqQKxoGOGr5375ZMz9j1kGL6p82782DPYZOrBe/bXLeFnslQD+Rr?=
 =?us-ascii?Q?RX4CuSb9fuMnJPg9Jz6frxOK9BLArIA90p8ZVSULvWP/mQqR40qyY4HNl64r?=
 =?us-ascii?Q?UZJA7rrwn1eIMY/2CpJ2m7oJ1G6tmp1j2IQcKVEjZy3vy2ezTTH05YkG/zAb?=
 =?us-ascii?Q?Xo8Hn4yK3XMifB+g9iXS04Oz0fKaNWw/GvLhgMWIt1Prr16eEljKZ/Y1M1wi?=
 =?us-ascii?Q?WllgEKsTgk5+q1Xr30cSh71MVrelGmTr6jlRQmEi5jtMhgxuMO2Mbkfpv0Kp?=
 =?us-ascii?Q?CmlQ8a9YB7Yx1rUmWk6kvfkIyt1FuKnywH9pNya2uJzto3PmDj+x76FsTuRV?=
 =?us-ascii?Q?WloSnmfaHdQALDmWNyMNu9+IhIt/2cpnMlr2aD142zAKGyjkEz3DQmy4Gyeu?=
 =?us-ascii?Q?O2/Mroa0VEs2zzus2ZxCcHyr1sVenVueizaiKSsNfi3d0+TB1Wq6XNIyUiJ3?=
 =?us-ascii?Q?8yIdA1rwnFEeJux1dZCaq4aV4md8yhWb7gvqfqKBDUFaHXngHbz3Q3i91Wq2?=
 =?us-ascii?Q?cLzGHDgWPIulRQI1W9Z0ALH/sZhBER1K6p3ZQSUVWu+1EapWL6rJcEbLgvXL?=
 =?us-ascii?Q?vKGikViQAfbgWfiz+qari19jAswRPTut32VMv/Cg/4o/ZRhfbUlygfgsoni6?=
 =?us-ascii?Q?9lIKYCVlwq/cD0P3PsRh3Vk7RyGrHiVGYAFLoX0fciK1MgaJoJvtWa0WIsba?=
 =?us-ascii?Q?tO0hU6qieRg5hok6P78j3xIXkRcebOMc0CMDsHK0PnQpdvf7b/5mbIZHW0F/?=
 =?us-ascii?Q?70yz6MTztqm0q8r3MVyv9dHNgGQDNf052WeW4GeSD4GMaKBMxynL+2CVzEGr?=
 =?us-ascii?Q?FA9OEDz6lNcXmHTFe/vtq61MV40X1lAXOjE8xlERASQRdAP4nZkZDkmAtnon?=
 =?us-ascii?Q?aNM6ZWrMuGHPynZFIN+CI4nNUIT2kv0o69y8LRESlrq07cvzK+XxIlJ7la54?=
 =?us-ascii?Q?1aNdmdYhvaJOxiibjEAS+3Y7AS9JhBy8ONroE5haOCS7EGKz6/7gkeqnNZ7D?=
 =?us-ascii?Q?IA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB5481.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f7f7197-f92d-44ae-eaa4-08d9b03a902d
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2021 17:39:42.2707
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: L6W6CY6g79Zq+QfdTHtuXLENWc4oWkCJauZ4hvPu8aKU5WZgeYc0EcyU8DV5i5Vav4swv9LncaSFWj88djpFgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5482
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Thursday, November 25, 2021 9:46 PM
>=20
> On Thu, Nov 25, 2021 at 10:03:28AM +0300, Dan Carpenter wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.=
git
> master
> > head:   5d9f4cf36721aba199975a9be7863a3ff5cd4b59
> > commit: 33b347503f014ebf76257327cbc7001c6b721956 vdpa: Define vdpa
> > mgmt device, ops and a netlink interface
> > config: i386-randconfig-m021-20211118
> > (https://download.01.org/0day-
> ci/archive/20211125/202111250317.VUsGtdo
> > x-lkp@intel.com/config)
> > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > smatch warnings:
> > drivers/vdpa/vdpa.c:296 vdpa_mgmtdev_fill() warn: should '(((1))) << (m=
dev-
> >id_table[i]->device)' be a 64 bit type?
> >
> > vim +296 drivers/vdpa/vdpa.c
> >
> > 33b347503f014eb Parav Pandit 2021-01-05  280  static int
> vdpa_mgmtdev_fill(const struct vdpa_mgmt_dev *mdev, struct sk_buff *msg,
> > 33b347503f014eb Parav Pandit 2021-01-05  281  			     u32
> portid, u32 seq, int flags)
> > 33b347503f014eb Parav Pandit 2021-01-05  282  {
> > 33b347503f014eb Parav Pandit 2021-01-05  283  	u64
> supported_classes =3D 0;
> >                                                 ^^^^^^^^^^^^^^^^^^^^^
> > This is a u64
> >
> > 33b347503f014eb Parav Pandit 2021-01-05  284  	void *hdr;
> > 33b347503f014eb Parav Pandit 2021-01-05  285  	int i =3D 0;
> > 33b347503f014eb Parav Pandit 2021-01-05  286  	int err;
> > 33b347503f014eb Parav Pandit 2021-01-05  287
> > 33b347503f014eb Parav Pandit 2021-01-05  288  	hdr =3D
> genlmsg_put(msg, portid, seq, &vdpa_nl_family, flags,
> VDPA_CMD_MGMTDEV_NEW);
> > 33b347503f014eb Parav Pandit 2021-01-05  289  	if (!hdr)
> > 33b347503f014eb Parav Pandit 2021-01-05  290  		return -
> EMSGSIZE;
> > 33b347503f014eb Parav Pandit 2021-01-05  291  	err =3D
> vdpa_nl_mgmtdev_handle_fill(msg, mdev);
> > 33b347503f014eb Parav Pandit 2021-01-05  292  	if (err)
> > 33b347503f014eb Parav Pandit 2021-01-05  293  		goto msg_err;
> > 33b347503f014eb Parav Pandit 2021-01-05  294
> > 33b347503f014eb Parav Pandit 2021-01-05  295  	while (mdev-
> >id_table[i].device) {
> > 33b347503f014eb Parav Pandit 2021-01-05 @296
> 	supported_classes |=3D BIT(mdev->id_table[i].device);
> >
> > Which suggests that this should be BIT_ULL().
> >
> > 33b347503f014eb Parav Pandit 2021-01-05  297  		i++;
> > 33b347503f014eb Parav Pandit 2021-01-05  298  	}
> > 33b347503f014eb Parav Pandit 2021-01-05  299
> > 33b347503f014eb Parav Pandit 2021-01-05  300  	if
> (nla_put_u64_64bit(msg, VDPA_ATTR_MGMTDEV_SUPPORTED_CLASSES,
> > 33b347503f014eb Parav Pandit 2021-01-05  301
> supported_classes, VDPA_ATTR_UNSPEC)) {
> > 33b347503f014eb Parav Pandit 2021-01-05  302  		err =3D -
> EMSGSIZE;
> > 33b347503f014eb Parav Pandit 2021-01-05  303  		goto msg_err;
> > 33b347503f014eb Parav Pandit 2021-01-05  304  	}
> > 33b347503f014eb Parav Pandit 2021-01-05  305
> > 33b347503f014eb Parav Pandit 2021-01-05  306  	genlmsg_end(msg,
> hdr);
> > 33b347503f014eb Parav Pandit 2021-01-05  307  	return 0;
> > 33b347503f014eb Parav Pandit 2021-01-05  308 33b347503f014eb Parav
> > Pandit 2021-01-05  309  msg_err:
> > 33b347503f014eb Parav Pandit 2021-01-05  310  	genlmsg_cancel(msg,
> hdr);
> > 33b347503f014eb Parav Pandit 2021-01-05  311  	return err;
> > 33b347503f014eb Parav Pandit 2021-01-05  312  }
>=20
>=20
> Parav? Any patches for this one?

Thanks Dan for reporting.

There are no in kernel drivers today that can register vdpa device with dev=
ice id > 31.
But I agree that this code should not assume that.
I will shortly supply a patch to fix this warning.