Date:   Thu, 25 Nov 2021 09:50:29 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc:     davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
        gregory.clement@bootlin.com, Andrew Lunn <andrew@lunn.ch>,
        Pali =?UTF-8?B?Um9ow6Fy?= <pali@kernel.org>
Subject: Re: [PATCH net-next 4/4] net: mvneta: Add TC traffic shaping
 offload
Message-ID: <20211125095029.342b3594@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20211125154813.579169-5-maxime.chevallier@bootlin.com>
References: <20211125154813.579169-1-maxime.chevallier@bootlin.com>
        <20211125154813.579169-5-maxime.chevallier@bootlin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 25 Nov 2021 16:48:13 +0100 Maxime Chevallier wrote:
> The mvneta controller is able to do some tocken-bucket per-queue traffic
> shaping. This commit adds support for setting these using the TC mqprio
> interface.
> 
> The token-bucket parameters are customisable, but the current
> implementation configures them to have a 10kbps resolution for the
> rate limitation, since it allows to cover the whole range of max_rate
> values from 10kbps to 5Gbps with 10kbps increments.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Breaks 32bit build, please make sure you use division helpers for 64b.