Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30B87C433FE for ; Thu, 25 Nov 2021 20:21:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357057AbhKYUYl (ORCPT ); Thu, 25 Nov 2021 15:24:41 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:54510 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242493AbhKYUWk (ORCPT ); Thu, 25 Nov 2021 15:22:40 -0500 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1637871568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2A2mtNS0DKb6dqqC8o4MSgl7FirJUel4InUDXfuBsIU=; b=WFJAiSeqjB5Ake1IU06h2j5Tz+P3t5+Tb+xdEXSAOOby2u2MJW0HNDB/rnbS/+u1lCMikt gj+RdlOIaraI4ywlzXKL+84KrL6Th/FCWIJqOVcKrdeG0Zvr4mPw9XPaIPmtgXg7NvBJv6 bryFPV6247oMJ6M7j05cVpv9QH0gMrIGM6/zuYcwaxtr2CYOUrj1cV6Pu6ERAgaddBsWk3 LPZQxfoFyL2BW/om5cpQkxRzzARCN8ME/AHd30a+nI9gW3V7EoxqT736g/29kD+UmtjIAa HrvMI+5d7hfZD8ZzuyoI3p/Fbges7W8QlR44/0gyOJ+N9AnlkXFsliRg6ACYjw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1637871568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2A2mtNS0DKb6dqqC8o4MSgl7FirJUel4InUDXfuBsIU=; b=numU1eF43/7g4E/13NfyMmKRCWlWbIgLyDATF3KhsASL6HGQuWcQn0p4hOL8R8gD4sSoIs DKt3LxoQdEF11KBQ== To: isaku.yamahata@intel.com, Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , erdemaktas@google.com, Connor Kuehl , Sean Christopherson , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: isaku.yamahata@intel.com, isaku.yamahata@gmail.com, Sean Christopherson , Xiaoyao Li Subject: Re: [RFC PATCH v3 47/59] KVM: TDX: Define TDCALL exit reason In-Reply-To: References: Date: Thu, 25 Nov 2021 21:19:27 +0100 Message-ID: <87k0gwhttc.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 24 2021 at 16:20, isaku yamahata wrote: > From: Sean Christopherson > > Define the TDCALL exit reason, which is carved out from the VMX exit > reason namespace as the TDCALL exit from TDX guest to TDX-SEAM is really > just a VM-Exit. How is this carved out? What's the value of this word salad? It's simply a new exit reason. Not more, not less. So what? > Co-developed-by: Xiaoyao Li > Signed-off-by: Xiaoyao Li > Signed-off-by: Sean Christopherson I'm pretty sure that it does not take two engineers to add a new exit reason define, but it takes at least two engineers to come up with a convoluted explanation for it. Thanks, tglx