Subject: Re: [PATCH v2 2/2] drm/amdkfd: Slighly optimize
 'init_doorbell_bitmap()'
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <cebaed4e892db804eece363e07a3ddd04af0f7be.1637700315.git.christophe.jaillet@wanadoo.fr>
 <72ac7967f07e0794a8a06793407cf03f6a34e9fa.1637700315.git.christophe.jaillet@wanadoo.fr>
From:   Felix Kuehling <felix.kuehling@amd.com>
Message-ID: <549df417-2aee-55f4-78f4-d6dec478ffa7@amd.com>
Date:   Thu, 25 Nov 2021 16:37:08 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <72ac7967f07e0794a8a06793407cf03f6a34e9fa.1637700315.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1ZsRDEyVFNtZW1YUDBhNlhibjZnT3lHTTZ0Rm55WURrSjhOUUpzRGVOdXJk?=
 =?utf-8?B?MVZRL1FtMmRYOEdlNTdOQUhBWksyM2tNUjMwczZNQTV0RExRM1JPVzRpQUQx?=
 =?utf-8?B?OCswSFVhaDNLY09rb0w5QldzNzVMM01rU2RsV0ZhZVZodzlPc3FMeGFWRUF2?=
 =?utf-8?B?ZXR2dUp1YkwwWDBGcXludDQzL2lUdEM0T0t3UTZuNU0yaC9XZXR4OEg2RTAz?=
 =?utf-8?B?MUEwMG1Bd3lORHQxazRscEEzbWtPc24rTHo2Nk9ENzVMRTBCTDc4OVNHSGgy?=
 =?utf-8?B?THRiMjYyUzJNeTJLWktFU1lmZE5GUkJxbjNEQnhOem54K0ZKRlg5OVRyTHlZ?=
 =?utf-8?B?Ymw1R2hNTlJBTFI5VE5ERVZ4RzlZb3BNWGI3d1JTU0QyZURVenZ3U1JwOUM2?=
 =?utf-8?B?dGpQNEdFSERKOFE5OTdobkRZWUpZakRpRXhvbFVzZExqaVlieHlhS1Rzc2FK?=
 =?utf-8?B?aHhwbkIvN0o0TjNBR092Y1IyMVJpVE9OS0xJVCtwS1ZIK0szb3NBeUxKa1A3?=
 =?utf-8?B?WTBNOHhsTk5UTXBBVklDMDhhZlk3VGJmUUx2WmhXNmllN1EyeHF1MjF4OWJT?=
 =?utf-8?B?ZVJsTkdnaG5IdlIxdTRRWVdSUnlzY0VqUzhIR1lCSWJJU1FNbEE0Z1ZIV3F2?=
 =?utf-8?B?UjRvS0NIS0lJbHc1clZVTlorTm5PanYzNEZoOC9tRVQxUUpSSThqeG1SWGFz?=
 =?utf-8?B?S042emxQOG1KRjJCNXBVVGJTaEk5bEsxTFZoK0ZrbkE5YnJ0MUVKQStHZkVR?=
 =?utf-8?B?a0l1bDJjVDc3eHpITlJEc3BmMGE5NWNuOUo5YmcxVVlZSnNLVXNab3JnZXJm?=
 =?utf-8?B?d3I3U0Z1aUkzQkUvRVZkMlJhdHk4aWtYOW1UNEhUdU84VTVSaGpISXVqc3hU?=
 =?utf-8?B?bS84RjVDdXVkTXphcjdYZDZMUXNhT1dhNWNkZnhydk1lQnEwRnc1bEpkNWRU?=
 =?utf-8?B?SFM5cTA5NmZ2d2tUN0NIVzNoeng2YVlWQnVyZFFMLzEvMi9xWnBxYkQ3NENj?=
 =?utf-8?B?OXN3Mm1vLzdqK0w5RE0ySTFYWDNyR2JFd2hNUVBBYXdKZ1RMcFJYS044dE1j?=
 =?utf-8?B?T0FSSnZzRHdYL29DT09OR21jb3VuLzFNVnNvRkZVYVlHRmk1WGovUHZUZ2pZ?=
 =?utf-8?B?YWZmVHpKKzlEekFuOHdBZGlJVTBrd25MeFZXMkI4MmZlOUllNnRuTm8zVzRK?=
 =?utf-8?B?U1g2NXJlOVA3QUttK3E3SHBtSWNCbXFJRUFORjdFUy9KYXROK0pCSEpYR0hM?=
 =?utf-8?B?UzJ5V2NSVnBObG5XTk55Njk2VEZYRzRKWS9TS3hJblpBNWh2enJiOFRvWFhB?=
 =?utf-8?B?RUFHamFnbFpiMXNPNndGQmlabVdlcTk3K1c4cDlpRlV2dTZDbWJKbjdMdkF2?=
 =?utf-8?B?Y3VYajRWZHZ0NmU1S3pOWXVMdng1cHB0SkFDUnZ3M0w3WStQMm9MUE56Q0dk?=
 =?utf-8?B?RFBTc3hXRTAvL0c4T3hxaEJMeHQvTkRPbElFcnFjbEZjZVFVeUhVZmJlWmp5?=
 =?utf-8?B?QjRsTU9saGdDN1VDSHc0ejU2a3g2Qlh6WW5lR0drWXBtYjdRb25YTUVlNzh3?=
 =?utf-8?B?dWZlc2lMZUpjL1diMDUzck10RGs2eHJ5TFlDa2ViTnNuWVozUFNmWnBsbG9m?=
 =?utf-8?B?b3IvR1N1S0xPWlZSd0dvU1NlSGs2MkhmRUlwNGVxelJWdXVOamJOcUlxeE9r?=
 =?utf-8?B?YitmcVdMWVhyOXh5dGV3MTFSNjFhc2pxMVE1Qlhndm9kQncrbTh3ME1nMGFT?=
 =?utf-8?B?eStXVHNaS3J0R3VNd3kvdGhFbm14QkY3L1ZUYWFycld2cHUwWk80NGlGeGtN?=
 =?utf-8?B?UWJ5RXNOZkhLdEo1OStlTW1NdFdsTVZvbGRzWkNkRit3TGowQTRYdEdIck1N?=
 =?utf-8?B?Zkx0MisyZHJ6K1g5TTJFbkpPZHpuRUV1R083UERVNXE1MGFLaGUwUFcrYnBK?=
 =?utf-8?B?R2dTSDZhbDB4U3dHdDZ6OWRqTjJWc2FZY3NNb2NLZGdaUFRKNFB1VVNXSE9F?=
 =?utf-8?B?emJERDFxSnVvTXlwNElkWjFhSDRSUHZqU2J0aGdaN1RpQjZLUExBTnlDMlo3?=
 =?utf-8?B?Tm5sNEdvKzBoby9leGdWUzA1VExmZENpbjVJcGdyMHBTT004Z2NhTkVTTENs?=
 =?utf-8?B?V2U4c2cybkhOVmQ0V1k2S0IrSTlIeWRwQ0dVamNkeHgxM0ZyZ3FyMHdJdEts?=
 =?utf-8?Q?Qa/GyBHJj7ES19u6Bx2EJYA=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b84fb395-534c-4776-8b70-08d9b05bbc5f
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2021 21:37:10.4385
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /8oN8PF1usGnuggEfzbjnA080809AMyLMvbbQUtE0ZcCNnv02OTkeS1n32rYn6vEbSvPn9PP9Os3fKgXODSM/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5338
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 2021-11-23 um 3:46 p.m. schrieb Christophe JAILLET:
> The 'doorbell_bitmap' bitmap has just been allocated. So we can use the
> non-atomic '__set_bit()' function to save a few cycles as no concurrent
> access can happen.
>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Thank you! I applied the series to amd-staging-drm-next.

Regards,
  Felix


> ---
> bitmap_set() could certainly also be use, but range checking would be
> tricky.
>
> v1 --> v2: No change
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_process.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index 67bb1654becc..9158f9754a24 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -1446,9 +1446,9 @@ static int init_doorbell_bitmap(struct qcm_process_device *qpd,
>  
>  	for (i = 0; i < KFD_MAX_NUM_OF_QUEUES_PER_PROCESS / 2; i++) {
>  		if (i >= range_start && i <= range_end) {
> -			set_bit(i, qpd->doorbell_bitmap);
> -			set_bit(i + KFD_QUEUE_DOORBELL_MIRROR_OFFSET,
> -				qpd->doorbell_bitmap);
> +			__set_bit(i, qpd->doorbell_bitmap);
> +			__set_bit(i + KFD_QUEUE_DOORBELL_MIRROR_OFFSET,
> +				  qpd->doorbell_bitmap);
>  		}
>  	}
>