Date:   Fri, 26 Nov 2021 09:36:56 +1100 (AEDT)
From:   Finn Thain <fthain@linux-m68k.org>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
cc:     Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Michael Schmitz <schmitzmic@gmail.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Jens Axboe <axboe@kernel.dk>, linux-ide@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pata_falcon: Add missing __iomem annotations
In-Reply-To: <CAMuHMdXy-XyR5PtczK9J1p_i=jugp4yq6JF8_MhVC1FMK5dtPw@mail.gmail.com>
Message-ID: <9713ea83-b4e7-4eee-5ab1-7fb2dccb4ccd@linux-m68k.org>
References: <44e0213a681f3c8ee4c6ab2ef9d61ce3ac00e368.1637727935.git.fthain@linux-m68k.org> <CAMuHMdXTxTABOoVgC6fVR44dxUZZEbZV=ewSk9vKFY=U5u+fcw@mail.gmail.com> <35a85d2f-ab6a-4ab7-85a8-626f1560a57d@linux-m68k.org>
 <CAMuHMdXy-XyR5PtczK9J1p_i=jugp4yq6JF8_MhVC1FMK5dtPw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 25 Nov 2021, Geert Uytterhoeven wrote:

> 
> Yeah, you do have to be careful with macros that derive a size from the 
> type of the passed data.  The *{in,out}sw() functions do not suffer from 
> that: they are defined to operate on a 16-bit I/O register. It is very 
> unlikely these semantics will ever change.
> 
> Here I'm more worried about the other danger: keeping casts will silence 
> any warning that may be introduced in a future change to the driver 
> code.
> 

Fair enough. I'll send v2.