MIME-Version: 1.0
References: <20211125110738.41028-1-nbd@nbd.name> <20211125110738.41028-12-nbd@nbd.name>
In-Reply-To: <20211125110738.41028-12-nbd@nbd.name>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Fri, 26 Nov 2021 02:19:48 +0100
Message-ID: <CACRpkdYVqk0JzVipvg_2oqg86A2enba_GyhPgXPxdKp-brxTGw@mail.gmail.com>
Subject: Re: [PATCH v4 11/12] dt-bindings: arm: airoha: Add binding for Airoha
 GPIO controller
To:     Felix Fietkau <nbd@nbd.name>
Cc:     linux-arm-kernel@lists.infradead.org,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Rob Herring <robh+dt@kernel.org>,
        John Crispin <john@phrozen.org>, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Felix,

thanks for your patch!

On Thu, Nov 25, 2021 at 12:24 PM Felix Fietkau <nbd@nbd.name> wrote:

> From: John Crispin <john@phrozen.org>
>
> Airoha's GPIO controller on their ARM EN7523 SoCs consists of two banks of 32
> GPIOs
>
> Signed-off-by: John Crispin <john@phrozen.org>

(...)

> +  reg:
> +    maxItems: 4

Can we write some short description on what the four different regs
are?

With that fixed:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij