MIME-Version: 1.0
References: <20211125180915.649652-1-parav@nvidia.com>
In-Reply-To: <20211125180915.649652-1-parav@nvidia.com>
From:   Jason Wang <jasowang@redhat.com>
Date:   Fri, 26 Nov 2021 10:48:12 +0800
Message-ID: <CACGkMEtF+kjj_vryxXAo6PqeX3Puk-XxaaQMcu4mhB1WZRXEpw@mail.gmail.com>
Subject: Re: [PATCH] vdpa: Consider device id larger than 31
To:     Parav Pandit <parav@nvidia.com>
Cc:     virtualization <virtualization@lists.linux-foundation.org>,
        mst <mst@redhat.com>, Eric Dumazet <edumazet@google.com>,
        kbuild-all@lists.01.org, kernel test robot <lkp@intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>, kbuild@lists.01.org,
        Eli Cohen <elic@nvidia.com>,
        Dan Carpenter <dan.carpenter@oracle.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 26, 2021 at 2:09 AM Parav Pandit <parav@nvidia.com> wrote:
>
> virtio device id value can be more than 31. Hence, use BIT_ULL in
> assignment.
>
> Fixes: 33b347503f01 ("vdpa: Define vdpa mgmt device, ops and a netlink interface")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Parav Pandit <parav@nvidia.com>

Acked-by: Jason Wang <jasowang@redhat.com>

> ---
>  drivers/vdpa/vdpa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
> index 7332a74a4b00..e91c71aeeddf 100644
> --- a/drivers/vdpa/vdpa.c
> +++ b/drivers/vdpa/vdpa.c
> @@ -404,7 +404,7 @@ static int vdpa_mgmtdev_fill(const struct vdpa_mgmt_dev *mdev, struct sk_buff *m
>                 goto msg_err;
>
>         while (mdev->id_table[i].device) {
> -               supported_classes |= BIT(mdev->id_table[i].device);
> +               supported_classes |= BIT_ULL(mdev->id_table[i].device);
>                 i++;
>         }
>
> --
> 2.26.2
>