Date:   Fri, 26 Nov 2021 07:43:34 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Cai Huoqing <caihuoqing@baidu.com>
Cc:     Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v3 1/3] staging: zynpu: Add driver support for ARM(China)
 ZHOUYI AI accelerator
Message-ID: <YaCCFv2DLzeng+UE@kroah.com>
References: <20211126021904.32325-1-caihuoqing@baidu.com>
 <20211126021904.32325-2-caihuoqing@baidu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211126021904.32325-2-caihuoqing@baidu.com>
Precedence: bulk

On Fri, Nov 26, 2021 at 10:18:59AM +0800, Cai Huoqing wrote:
> ZHOUYI NPU is an AI accelerator chip which is integrated into ARM SOC,
> such as Allwinner R329 SOC.
> Add driver support for this AI accelerator here.
> 
> This driver is not standard linux style, there are some clean up works,
> fixing code style, refactorring.
> And it only works with a closed source usermode driver, so need to
> reverse the libraries, and impelement it, then open source
> the usermode driver.
> So add this driver to linux-staging

Sorry, but no, I can not take this driver into the kernel tree until
there is an open source user of the new api that you are creating with
this driver.  This was discussed many times on the linux-kernel mailing
list and at the Linux kernel summit a few months ago (see the summary at
lwn.net about it.)

So please work on that first, and then we will be glad to revisit taking
this kernel driver into the tree.

Also, it is much simpler just to take a few hours and clean up the
coding style issues yourself rather than relying on the community to do
it for you over a few months.

thanks,

greg k-h