MIME-Version: 1.0
References: <20211126060024.3290177-1-alistair.francis@opensource.wdc.com> <20211126060024.3290177-6-alistair.francis@opensource.wdc.com>
In-Reply-To: <20211126060024.3290177-6-alistair.francis@opensource.wdc.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Fri, 26 Nov 2021 08:33:53 +0100
Message-ID: <CAK8P3a3EMyg5SuKnbjnUvUhRkoqNuWoEPh_hoTU4abjR4a8PgQ@mail.gmail.com>
Subject: Re: [PATCH v3 6/6] selftests: futex: Use futex_waitv helper function
To:     Alistair Francis <alistair.francis@opensource.wdc.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Arnd Bergmann <arnd@arndb.de>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Alistair Francis <alistair23@gmail.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Ingo Molnar <mingo@redhat.com>,
        Darren Hart <dvhart@infradead.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-perf-users@vger.kernel.org,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Alistair Francis <alistair.francis@wdc.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 26, 2021 at 7:00 AM Alistair Francis
<alistair.francis@opensource.wdc.com> wrote:
>
> From: Alistair Francis <alistair.francis@wdc.com>
>
> Use the publically exposed __kernel_futex_syscall_waitv() helper
> function for the futex_waitv tests.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>

I think it would be nicer to wrap __kernel_futex_syscall_waitv() here

> -static inline int futex_waitv(volatile struct futex_waitv *waiters, unsigned long nr_waiters,
> -                             unsigned long flags, struct timespec *timo, clockid_t clockid)
> -{
> -       return syscall(__NR_futex_waitv, waiters, nr_waiters, flags, timo, clockid);
> -}

Basically just changing this part to call the new function

         Arnd