From:   "Colin King (gmail)" <colin.i.king@googlemail.com>
Message-ID: <dcd6ed6a-a915-49b5-a428-f21f2e3e3e00@gmail.com>
Date:   Fri, 26 Nov 2021 08:29:59 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH][next] hugetlb: Fix spelling mistake "hierarichal" ->
 "hierarchical"
Content-Language: en-US
To:     Joe Perches <joe@perches.com>,
        Colin Ian King <colin.i.king@googlemail.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211125090635.23508-1-colin.i.king@gmail.com>
 <aa7ad39528c768dfd3a33890cf7d14b59ba3a5fc.camel@perches.com>
In-Reply-To: <aa7ad39528c768dfd3a33890cf7d14b59ba3a5fc.camel@perches.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 26/11/2021 08:15, Joe Perches wrote:
> On Thu, 2021-11-25 at 09:06 +0000, Colin Ian King wrote:
>> There is a spelling mistake in a literal string and a comment. Fix them.
> []
>> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
> []
>> @@ -495,11 +495,11 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy)
>>   	 * The hierarchical total is pretty much the value recorded by the
>>   	 * counter, so use that.
>>   	 */
>> -	seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "",
>> +	seq_printf(seq, "%stotal=%lu", legacy ? "hierarchical_" : "",
>>   		   page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE);
> 
> Not sure this should be changed as seq output is nominally ABI.

This just landed in linux-next, so I doubt many folk are using it. Let's 
fix it before it lands mainline.

> 
>>   
>>   	/*
>> -	 * For each node, transverse the css tree to obtain the hierarichal
>> +	 * For each node, transverse the css tree to obtain the hierarchical
> 
> Fixing the comment typo is good.  Thanks.
> 
>