From:   Manish Rangankar <mrangankar@marvell.com>
To:     Florian Fainelli <f.fainelli@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     kernel test robot <lkp@intel.com>,
        Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "open list:QLOGIC QL41xxx ISCSI DRIVER" <linux-scsi@vger.kernel.org>
Subject: RE: [EXT] [PATCH 1/2] scsi: qedi: Remove set but unused 'page'
 variable
Thread-Topic: [EXT] [PATCH 1/2] scsi: qedi: Remove set but unused 'page'
 variable
Thread-Index: AQHX4oSo8afFlgxayk6RzvRV857OjawVgMlg
Date:   Fri, 26 Nov 2021 08:52:29 +0000
Message-ID: <CO6PR18MB44199C2AE98B79EE9D46D679D8639@CO6PR18MB4419.namprd18.prod.outlook.com>
References: <20211126051529.5380-1-f.fainelli@gmail.com>
 <20211126051529.5380-2-f.fainelli@gmail.com>
In-Reply-To: <20211126051529.5380-2-f.fainelli@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tk977iVpFc5IYqKJNxUbQylVN07lWRmU2rpLLreh2aqRiJ+otjACt7Fj6sEa?=
 =?us-ascii?Q?Ssy4CTcsPT+DESkrtaA/M+Pjv0R1evOl10NGJ2Jk/JwtzjoAsTEKASBT64rh?=
 =?us-ascii?Q?27KEr49+b8NUhBisGQ4DNKb8aAMAWAUlAoenb//2c2B8csynhBwLAay1aOjc?=
 =?us-ascii?Q?uOcH+wEKPxb4uyWPCP48wGv90BgyvMmdCBbSiXcs2mJicDvKuBvJKX4PQjtS?=
 =?us-ascii?Q?F6r+Zxw67m6ZYhKUn9A0FaakH+h1nsm1EnPXoDoTteiAzsmk47YobjI3cssF?=
 =?us-ascii?Q?v5OKmU281P7Kjngtg0IfRb6daOjhKomYl+u/hUUoZ9MPWZCqHdrCXGW/A/fQ?=
 =?us-ascii?Q?WmXfdcyeoPdRRkUQRMuH6JrwCuX/pYb9nTp0sgwufFB7CV13rBK074F6RNrG?=
 =?us-ascii?Q?co9sKH87eqqgELute0tUYY+qT/edwDCHG1mCJzA0WMM5M5qM5Lm8WXO6zhw/?=
 =?us-ascii?Q?kk5ktZSKwrKFsMcpgXBXynuQoHPsZrR3pi1LcfPpM6rhE8QLV3iRYVAv9dEF?=
 =?us-ascii?Q?CN8gAJq2y6hB6FYZaS/siCI7+yC7RviaKDX8WAc8saUPSkiKmucvI5qRZqS5?=
 =?us-ascii?Q?d76DEwZ6/lbBGSZg2vgXx0tKh33kw52uNt6iXyW5ir3hmPJHic7QX3f1lTB8?=
 =?us-ascii?Q?VWrg3IslrQ7oOmR4fz2i1lk3Dm+qWhWi299/sK5uPuUQRcQlHhmHMain15I4?=
 =?us-ascii?Q?nqVMjJ4wHBO9Hg6DXNVET6wU1gFOfGG7rbktNgRN+86T6OTR4+kUrz+jGnFL?=
 =?us-ascii?Q?AXFNKMOUnUDme68ETo/Tfxg0EkRAjnHRfUn8dTdHDncJEEyC1PS+LabPzbbe?=
 =?us-ascii?Q?PdWzSrKlchdhZ1XwgboWe1rSiG6zursQF4QYIaITRRFXJJHTxoiCGlU09kTV?=
 =?us-ascii?Q?3TJxgXGrtOscEwo7UhLmV03bu6V80c7n/HDCY7hNvIndYi9luIZnxjIFyiMw?=
 =?us-ascii?Q?0H6/vqDMPDrUeFPjCKA8sXlMnkln2Wu8F5sKvJVOAc+xg9GLP3K9OPPTfUUC?=
 =?us-ascii?Q?/tl7dmC2WvMEnQCj5m4zJRIuMp0qPthLnalNJ3NV3/cic6npm+d4QJk3R7u9?=
 =?us-ascii?Q?9qe9tU+y8bbr0K0sd48+ksneaCWqwHKa7a8oDjoOuW02angs7YId+WLIr7L7?=
 =?us-ascii?Q?xC561ONiZ0Fx5Xd+1drlxpaLhIQM9erjpCcyj5QGS4Sg4bXcGaI2+5sGSw0o?=
 =?us-ascii?Q?8R5kRLpxwgSoiPFgOg1H3N+qr842vw/aKDWk6ymja7CijpJa6V/eIyjtowFj?=
 =?us-ascii?Q?/KtFgnwjaNDsQXMznvvAx7Fh1ax3qFF/WUVVktrHTjWxxB+i4E7dHUGMM2EI?=
 =?us-ascii?Q?BOUDYLyhB0CCHp/w/AkHBo/QM4S8SHXd5raZCOFKzGFiWKLbzSQ/Abrrcd+/?=
 =?us-ascii?Q?jCeBBmCZK6Nb90GsMeXugFoRtQeAaJRtXHTgkYYiT3Mwc1BVcPuql2pipNk1?=
 =?us-ascii?Q?mZQt7YU1X2PFIg4qwlk6UlVyXrzPWLqla+fGxQ8UfpdtrPyzt4Pw6GjXQJ+5?=
 =?us-ascii?Q?KDqTcjDqIZTYSNz0VcmI7k7ysDhtj3tckR8c9zXv07zfXxkqBDghFrBv7hTI?=
 =?us-ascii?Q?rZjFM57cPAGHY/bWr7P1hyPIBa5VxReJwdd65ZGz4QXcp5utdcoOi/rUWS/j?=
 =?us-ascii?Q?vw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4419.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb511442-7140-4ab5-c788-08d9b0ba1455
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2021 08:52:29.9733
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XEnGdr79fvtmlo3fS3jlqx396O0i0rCMlrS8rU6HLahAt82btN+4rEW9MG1m10uYqTJZCdzHIYfgFIseGOVrnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4467
X-Proofpoint-GUID: LMOmNADs42ZKeTvseAwaYVhp-belUFNd
X-Proofpoint-ORIG-GUID: DFklVT2CA6m94PkAq0GRdbNfjGBdbJ16
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-11-26_02,2021-11-25_02,2020-04-07_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Florian Fainelli <f.fainelli@gmail.com>
> Sent: Friday, November 26, 2021 10:45 AM
> To: linux-kernel@vger.kernel.org
> Cc: Florian Fainelli <f.fainelli@gmail.com>; kernel test robot <lkp@intel=
.com>;
> Nilesh Javali <njavali@marvell.com>; Manish Rangankar
> <mrangankar@marvell.com>; GR-QLogic-Storage-Upstream <GR-QLogic-
> Storage-Upstream@marvell.com>; James E.J. Bottomley <jejb@linux.ibm.com>;
> Martin K. Petersen <martin.petersen@oracle.com>; open list:QLOGIC QL41xxx
> ISCSI DRIVER <linux-scsi@vger.kernel.org>
> Subject: [EXT] [PATCH 1/2] scsi: qedi: Remove set but unused 'page' varia=
ble
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> The variable page is set but never used throughout qedi_alloc_bdq() there=
fore
> remove it.
>=20
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  drivers/scsi/qedi/qedi_main.c | 3 ---
>  1 file changed, 3 deletions(-)
>=20
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.=
c index
> 1dec814d8788..f1c933070884 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -1538,7 +1538,6 @@ static int qedi_alloc_bdq(struct qedi_ctx *qedi)
>  	int i;
>  	struct scsi_bd *pbl;
>  	u64 *list;
> -	dma_addr_t page;
>=20
>  	/* Alloc dma memory for BDQ buffers */
>  	for (i =3D 0; i < QEDI_BDQ_NUM; i++) {
> @@ -1608,11 +1607,9 @@ static int qedi_alloc_bdq(struct qedi_ctx *qedi)
>  	qedi->bdq_pbl_list_num_entries =3D qedi->bdq_pbl_mem_size /
>  					 QEDI_PAGE_SIZE;
>  	list =3D (u64 *)qedi->bdq_pbl_list;
> -	page =3D qedi->bdq_pbl_list_dma;
>  	for (i =3D 0; i < qedi->bdq_pbl_list_num_entries; i++) {
>  		*list =3D qedi->bdq_pbl_dma;
>  		list++;
> -		page +=3D QEDI_PAGE_SIZE;
>  	}
>=20
>  	return 0;
> --
> 2.25.1

Thanks,
Acked-by: Manish Rangankar <mrangankar@marvell.com>