MIME-Version: 1.0
References: <20211125090635.23508-1-colin.i.king@gmail.com>
 <aa7ad39528c768dfd3a33890cf7d14b59ba3a5fc.camel@perches.com> <dcd6ed6a-a915-49b5-a428-f21f2e3e3e00@gmail.com>
In-Reply-To: <dcd6ed6a-a915-49b5-a428-f21f2e3e3e00@gmail.com>
From:   Muchun Song <songmuchun@bytedance.com>
Date:   Fri, 26 Nov 2021 16:57:29 +0800
Message-ID: <CAMZfGtXJkEtH+nVMLtGhfVqySZ+iGc-1yd9OJ3jxK65puFgf_Q@mail.gmail.com>
Subject: Re: [PATCH][next] hugetlb: Fix spelling mistake "hierarichal" -> "hierarchical"
To:     "Colin King (gmail)" <colin.i.king@googlemail.com>
Cc:     Joe Perches <joe@perches.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 26, 2021 at 4:38 PM Colin King (gmail)
<colin.i.king@googlemail.com> wrote:
>
> On 26/11/2021 08:15, Joe Perches wrote:
> > On Thu, 2021-11-25 at 09:06 +0000, Colin Ian King wrote:
> >> There is a spelling mistake in a literal string and a comment. Fix them.
> > []
> >> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
> > []
> >> @@ -495,11 +495,11 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy)
> >>       * The hierarchical total is pretty much the value recorded by the
> >>       * counter, so use that.
> >>       */
> >> -    seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "",
> >> +    seq_printf(seq, "%stotal=%lu", legacy ? "hierarchical_" : "",
> >>                 page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE);
> >
> > Not sure this should be changed as seq output is nominally ABI.
>
> This just landed in linux-next, so I doubt many folk are using it. Let's
> fix it before it lands mainline.

Totally agree.

>
> >
> >>
> >>      /*
> >> -     * For each node, transverse the css tree to obtain the hierarichal
> >> +     * For each node, transverse the css tree to obtain the hierarchical
> >
> > Fixing the comment typo is good.  Thanks.
> >
> >
>